Name struct columns from parenthesised-star expressions after their source#4182
Name struct columns from parenthesised-star expressions after their source#4182arnaud-lacurie wants to merge 5 commits into
Conversation
…ource SELECT (T.*) now names the outer column after T; SELECT (*) from a single table names it after the table/alias. With multiple tables in scope the column remains anonymous.
📊 Metrics Diff Analysis ReportSummary
ℹ️ About this analysisThis automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:
The last category in particular may indicate planner regressions that should be investigated. New QueriesCount of new queries by file:
|
arnaud-lacurie
added
the
Run mixed-mode
| @@ -0,0 +1,115 @@ | |||
| # | |||
There was a problem hiding this comment.
Should we add a test for SELECT (*) FROM VALUES (1, 2), (3, 4) as well?
| @@ -1,6 +1,6 @@ | |||
| arrays-cardinality-tests: | |||
| - query: EXPLAIN SELECT CARDINALITY("int_arr") FROM "tab1_nn" | |||
| ref: arrays_cardinality.yamsql:72 | |||
There was a problem hiding this comment.
I am wondering how the yaml tests were passing with these queries missing from the metric files?
There was a problem hiding this comment.
I think we do not fail if the queries do not have a metrics file entry. I'll prepare a separate patch to fix that properly.
There was a problem hiding this comment.
Found why, it was a recently added regression, opened a PR to fix this in #4194. You can remove these metrics from this PR now since I had to add them to the bug-fix PR.
2 participants
SELECT (T.*)now produces a column namedT;SELECT (*)from a single table names the column after the table/alias. With multiple tables in scope the column remains unnamed.