Skip to content

Update Gradle from 8.14 to 9.5.1#4138

Open
RobertBrunel wants to merge 2 commits into
FoundationDB:mainfrom
RobertBrunel:gradle-2a
Open

Update Gradle from 8.14 to 9.5.1#4138
RobertBrunel wants to merge 2 commits into
FoundationDB:mainfrom
RobertBrunel:gradle-2a

Conversation

@RobertBrunel
Copy link
Copy Markdown
Contributor

@RobertBrunel RobertBrunel commented May 7, 2026

Update the Gradle wrapper, regenerate the wrapper jar and scripts, and pin the SHA256 of the new distribution.

Two plugins need updating alongside Gradle:

  • com.google.protobuf 0.9.4 to 0.9.6, which fixes a Gradle 9.1 deprecation in its ToolsLocator. For now, we need to stay below version 0.10.0, as that release makes generatedFilesBaseDir read-only and the setting in gradle/proto.gradle still needs to override it.

  • com.gradleup.shadow 8.3.5 to 8.3.10. Its startShadowScripts task references the mainClassName convention property, which Gradle 9 removes; version 8.3.7 restores compatibility. For now, we stay on the 8.3.* line because the version 9 rewrite introduces large breaking changes.

Also resolve further Gradle deprecation warnings after upgrading to Gradle 9.5:

  • In antlr.gradle, use the packageName property on AntlrTask instead of passing -package through arguments. The -package argument form is deprecated in Gradle 9.5 and will be removed in Gradle 10. packageName appends the package subdirectory to outputDirectory automatically, so outputDirectory is shortened accordingly. The packageName property was introduced in Gradle 9.1.

@RobertBrunel RobertBrunel requested a review from ScottDugas May 7, 2026 13:51
@RobertBrunel RobertBrunel self-assigned this May 7, 2026
@RobertBrunel RobertBrunel added the build improvement Improvement to the build system label May 7, 2026
@RobertBrunel RobertBrunel linked an issue May 7, 2026 that may be closed by this pull request
@MMcM MMcM mentioned this pull request May 7, 2026
@RobertBrunel RobertBrunel requested a review from MMcM May 8, 2026 09:02
@ScottDugas ScottDugas added the Run mixed-mode Label to add to Pull Requests to have it run mixed mode tests label May 8, 2026
Comment thread gradle/wrapper/gradle-wrapper.properties Outdated
Comment thread gradle/wrapper/gradle-wrapper.properties Outdated
@RobertBrunel RobertBrunel force-pushed the gradle-2a branch 3 times, most recently from 7a124ca to 74c9359 Compare May 15, 2026 08:52
@RobertBrunel RobertBrunel changed the title Update Gradle from 8.13 to 9.5.0 Update Gradle from 8.13 to 9.5.1 May 15, 2026
@RobertBrunel RobertBrunel requested a review from ScottDugas May 15, 2026 09:25
Comment thread gradle/wrapper/gradle-wrapper.properties Outdated
Update the Gradle wrapper, regenerate the wrapper jar and scripts, and pin the SHA256 of the new distribution.

Two plugins need updating alongside Gradle:

* `com.google.protobuf` 0.9.4 to 0.9.6, which fixes a Gradle 9.1 deprecation in its `ToolsLocator`. For now, we need to stay below version 0.10.0, as that release makes `generatedFilesBaseDir` read-only and the setting in `gradle/proto.gradle` still needs to override it.

* `com.gradleup.shadow` 8.3.5 to 8.3.10. Its `startShadowScripts` task references the `mainClassName` convention property, which Gradle 9 removes; version 8.3.7 restores compatibility. For now, we stay on the 8.3.* line because the version 9 rewrite introduces large breaking changes.
… 9.5

In `antlr.gradle`, use the `packageName` property on `AntlrTask` instead of passing `-package` through `arguments`. The `-package` argument form is deprecated in Gradle 9.5 and will be removed in Gradle 10. `packageName` appends the package subdirectory to `outputDirectory` automatically, so `outputDirectory` is shortened accordingly. The `packageName` property was introduced in Gradle 9.1.
@RobertBrunel RobertBrunel changed the title Update Gradle from 8.13 to 9.5.1 Update Gradle from 8.14 to 9.5.1 May 21, 2026
@RobertBrunel RobertBrunel requested a review from ScottDugas May 21, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build improvement Improvement to the build system Run mixed-mode Label to add to Pull Requests to have it run mixed mode tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Gradle 9

2 participants