MetaDataEvolutionValidator now validates synthetic record type evolution#4121
Draft
alecgrieser wants to merge 7 commits into
Draft
MetaDataEvolutionValidator now validates synthetic record type evolution#4121alecgrieser wants to merge 7 commits into
alecgrieser wants to merge 7 commits into
Conversation
…d renames only on deprecated types The `MetaDataEvolutionValidator` was given an option to allow for field renames with FoundationDB#4034. That can be problematic in the general case, as we don't really want fields that are in use to change their field name. (For example, if two fields swap places accidentlly but they have identical types, allowing general field renames wouldn't catch that.) However, if a field has been marked as deprecated, then it is likely no longer in use, so allowing field renames for those fields is less problematic. It is also the only way to support a flow that allows for a field to be recreated (e.g., with a new type), though that operation has its own costs. This resolves FoundationDB#4020.
…ution The `MetaDataEvolutionValidator` has been udpated here to look at the synthetic types in the meta-data. This allows it to validate that the data held in join indexes and unnested indexes is not incorrectly updated during meta-data evolution. There are largely analogous paths followed for the two current synthetic types, `JoinedRecordType`s and `UnnestedRecordType`s. This resolves FoundationDB#4022.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MetaDataEvolutionValidatorhas been udpated here to look at the synthetic types in the meta-data. This allows it to validate that the data held in join indexes and unnested indexes is not incorrectly updated during meta-data evolution. There are largely analogous paths followed for the two current synthetic types,JoinedRecordTypes andUnnestedRecordTypes.This resolves #4022.