diff --git a/libfcgi/fcgiapp.c b/libfcgi/fcgiapp.c index 99c3630..0cd3dd1 100644 --- a/libfcgi/fcgiapp.c +++ b/libfcgi/fcgiapp.c @@ -18,6 +18,7 @@ #include /* for memchr() */ #include #include +#include #include #include #include @@ -1160,6 +1161,7 @@ char *FCGX_GetParam(const char *name, FCGX_ParamArray envp) static int ReadParams(Params *paramsPtr, FCGX_Stream *stream) { int nameLen, valueLen; + size_t totalLen; unsigned char lenBuff[3]; char *nameValue; @@ -1175,7 +1177,7 @@ static int ReadParams(Params *paramsPtr, FCGX_Stream *stream) } nameLen = ((nameLen & 0x7f) << 24) + (lenBuff[0] << 16) + (lenBuff[1] << 8) + lenBuff[2]; - if (nameLen >= INT_MAX) { + if (nameLen >= INT_MAX || nameLen >= SIZE_MAX) { SetError(stream, FCGX_PARAMS_ERROR); return -1; } @@ -1191,16 +1193,21 @@ static int ReadParams(Params *paramsPtr, FCGX_Stream *stream) } valueLen = ((valueLen & 0x7f) << 24) + (lenBuff[0] << 16) + (lenBuff[1] << 8) + lenBuff[2]; - if (valueLen >= INT_MAX) { + if (valueLen >= INT_MAX || valueLen >= SIZE_MAX) { SetError(stream, FCGX_PARAMS_ERROR); return -1; } } + totalLen = (size_t)nameLen + (size_t)valueLen + 2u; + if (totalLen < (size_t)nameLen || totalLen < (size_t)valueLen) { + SetError(stream, FCGX_PARAMS_ERROR); + return -1; + } /* * nameLen and valueLen are now valid; read the name and value * from stream and construct a standard environment entry. */ - nameValue = (char *)Malloc(nameLen + valueLen + 2); + nameValue = (char *)Malloc(totalLen); if(FCGX_GetStr(nameValue, nameLen, stream) != nameLen) { SetError(stream, FCGX_PARAMS_ERROR); free(nameValue);