installfog.sh cannot upgrade FOG on Debian Trixie: "/lib/common/functions.sh: line 1526: lastlog: command not found"

[busdrw]

Describe the bug
When trying to upgrade FOG on Debian Trixie, installfog.sh fails because lastlog isn't installed. Debian Trixie removed the lastlog command.

To Reproduce
Steps to reproduce the behavior:

1. Have an existing FOG installation (1.5.10.1815) on Debian Trixie.
2. Go to an existing checkout of this repository and pull it
3. cd to bin and sudo ./installfog.sh -y
4. installfog.sh fails with the following error:

 * Configuring services

 * Setting up fogproject user..................................../lib/common/functions.sh: line 1526: lastlog: command not found
Already exists

The account "fogproject" already exists and has been used to
log in to this server. We highly recommend you NOT use this
account as it is supposed to be a system account!

Please remove the account "fogproject" manually before running
the installer again, or set the system username yourself.

To remove the account run: userdel fogproject

To set a new service username run installer with:
username=<usernameForSystem> ./installfog.sh -y

Expected behavior
installfog.sh proceeds as normal, as it did prior to Debian Trixie.

Software (please complete the following information):

• FOG version: 1.5.10.1815
• FOS kernel: N/A
• OS: Debian GNU/Linux 13 (trixie)

Additional context
System has been upgraded from previous Debian versions over the years, going back to 2018.

[lukebarone]

fogproject/lib/common/functions.sh

Line 1526 in 2309704

lastlog -u $username | tail -n1 | grep "\*\*.*\*\*" >/dev/null 2>&1

Maybe change the line to last fogproject | grep -Ev "wtmp|^$"? Error code 1 shows the user has NOT logged in before, while error code 0 shows they HAVE logged in before.

I don't see any other references to lastlog. Tested on my dev station, not on Debian proper.

---

Update (untested)

utmpdump /var/log/wtmp | grep fogproject | grep -Ev "^Utmp dump"

[busdrw]

Trixie also doesn't have last.

Might be best to skip the test for Trixie machines for now, or at least allow users to bypass it.

[lukebarone]

If it's being called, we should look at whether it's needed or not. It looks like that's the only place it's called, so we'll look for an alternative so it can be safely removed.

Thanks for checking about last - I don't have my FOG server accessible right now (day off), so I couldn't test fully (hence, I didn't push a patch yet ;) )