From ba6340cf4329dd033bfb125abedf6454f40f16d4 Mon Sep 17 00:00:00 2001 From: Leo Romanovsky Date: Mon, 3 Nov 2025 14:02:12 -0500 Subject: [PATCH 1/2] fix: improve Ruby SDK testing and fix conditional execution in CI workflows - Fix Ruby SDK testing missing conditional execution in test-sdk-packages.yml - Add consistent conditional execution to PHP, Python, and Go SDK tests - Add dedicated Ruby SDK testing job in test-sdks.yml calling ruby.yml workflow - Ensures SDK tests only run when test data changes or on main/workflow-test branches --- .github/workflows/test-sdk-packages.yml | 8 ++++++++ .github/workflows/test-sdks.yml | 6 ++++++ 2 files changed, 14 insertions(+) diff --git a/.github/workflows/test-sdk-packages.yml b/.github/workflows/test-sdk-packages.yml index fe79c52..ad0e907 100644 --- a/.github/workflows/test-sdk-packages.yml +++ b/.github/workflows/test-sdk-packages.yml @@ -42,6 +42,8 @@ jobs: sdk_testing_region: ${{ vars.SDK_TESTING_REGION }} test-php-sdk: + needs: check-path + if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false @@ -59,6 +61,8 @@ jobs: sdk_testing_region: ${{ vars.SDK_TESTING_REGION }} test-python-sdk: + needs: check-path + if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false @@ -76,6 +80,8 @@ jobs: sdk_testing_region: ${{ vars.SDK_TESTING_REGION }} test-ruby-sdk: + needs: check-path + if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false @@ -93,6 +99,8 @@ jobs: sdk_testing_region: ${{ vars.SDK_TESTING_REGION }} test-go-sdk: + needs: check-path + if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false diff --git a/.github/workflows/test-sdks.yml b/.github/workflows/test-sdks.yml index cb0d76d..c0822c2 100644 --- a/.github/workflows/test-sdks.yml +++ b/.github/workflows/test-sdks.yml @@ -46,6 +46,12 @@ jobs: test_data_branch: ${{ github.head_ref || github.ref_name }} sdk_branch: main + test-ruby-sdk: + uses: Eppo-exp/eppo-multiplatform/.github/workflows/ruby.yml@main + with: + test_data_branch: ${{ github.head_ref || github.ref_name }} + sdk_branch: main + test-multiplatform-sdk: uses: 'Eppo-exp/eppo-multiplatform/.github/workflows/ci.yml@main' with: From df0a8d72649b4df9f207ba818c43e249d5634d74 Mon Sep 17 00:00:00 2001 From: Leo Romanovsky Date: Mon, 3 Nov 2025 14:05:40 -0500 Subject: [PATCH 2/2] fix: remove conditional execution from CI workflows - restore original test behavior All SDK tests now run unconditionally on every push instead of only when test data changes. This ensures better test coverage and avoids issues with tests not running when expected. --- .github/workflows/test-sdk-packages.yml | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/.github/workflows/test-sdk-packages.yml b/.github/workflows/test-sdk-packages.yml index ad0e907..76c4d4d 100644 --- a/.github/workflows/test-sdk-packages.yml +++ b/.github/workflows/test-sdk-packages.yml @@ -7,24 +7,7 @@ on: - workflow-test/* jobs: - # Filter the changed paths so these jobs can run only on changes to the ufc test data, or if the current branch matches workflow-test/* - check-path: - runs-on: ubuntu-latest - outputs: - should_run: ${{ github.ref == 'refs/heads/main' && steps.filter.outputs.ufc == 'true' || startsWith(github.ref, 'refs/heads/workflow-test/') }} - steps: - - uses: actions/checkout@v4 - - uses: dorny/paths-filter@v2 - id: filter - with: - filters: | - ufc: - - 'ufc/**' - - '!ufc/**/*.md' - test-node-sdk: - needs: check-path - if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false @@ -42,8 +25,6 @@ jobs: sdk_testing_region: ${{ vars.SDK_TESTING_REGION }} test-php-sdk: - needs: check-path - if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false @@ -61,8 +42,6 @@ jobs: sdk_testing_region: ${{ vars.SDK_TESTING_REGION }} test-python-sdk: - needs: check-path - if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false @@ -80,8 +59,6 @@ jobs: sdk_testing_region: ${{ vars.SDK_TESTING_REGION }} test-ruby-sdk: - needs: check-path - if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false @@ -99,8 +76,6 @@ jobs: sdk_testing_region: ${{ vars.SDK_TESTING_REGION }} test-go-sdk: - needs: check-path - if: needs.check-path.outputs.should_run == 'true' runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-latest' || matrix.platform == 'macos' && 'macos-13' || matrix.platform == 'windows' && 'windows-latest' }} strategy: fail-fast: false