Skip to content

Transaction rollbacks #15

Description

@phizab

Is there a reason why there are no rollbacks in the module? At every transaction is only a commit, but as I know we need a rollback in case of an error. The commit should be wrapped with a try .. catch statement as follows:

$this->_getIndexAdapter()->beginTransaction();

[..]

try {
    $this->_getIndexAdapter()->commit();
} catch (Exception $e) {
    $this->_getIndexAdapter()->rollback();
}

Or am I wrong?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions