From 090aa9aeec9e24f16cc73c155ad765ae64b08ff4 Mon Sep 17 00:00:00 2001 From: Scott Lovegrove Date: Fri, 23 Oct 2026 11:37:58 +0100 Subject: [PATCH 1/2] refactor: delete filters through the REST endpoint `td filter delete` used the Sync `filter_delete` command. Switch to `deleteFilter()` from @doist/todoist-sdk 15.8.0, which calls the REST `DELETE /api/v1/filters/{id}` endpoint, matching how the other delete commands work. --- package-lock.json | 8 ++++---- package.json | 2 +- src/lib/api/filters.ts | 4 +--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3f1304b5..13f37fa6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,7 +11,7 @@ "license": "MIT", "dependencies": { "@doist/cli-core": "1.7.0", - "@doist/todoist-sdk": "15.7.0", + "@doist/todoist-sdk": "15.8.0", "@napi-rs/keyring": "2.1.1", "@pnpm/tabtab": "0.5.4", "chalk": "6.0.1", @@ -233,9 +233,9 @@ "license": "MIT" }, "node_modules/@doist/todoist-sdk": { - "version": "15.7.0", - "resolved": "https://registry.npmjs.org/@doist/todoist-sdk/-/todoist-sdk-15.7.0.tgz", - "integrity": "sha512-xsG7VoJAQXwep0KHo9rOfpW+sYjLZ8Dd0eSd6Qb7dyHD5UE44PwDcOzBBHR+7XWtUO1tANXRG5o1iPBk5N1x5A==", + "version": "15.8.0", + "resolved": "https://registry.npmjs.org/@doist/todoist-sdk/-/todoist-sdk-15.8.0.tgz", + "integrity": "sha512-mVDdmC/Wd6hzv35Ei3AlUCxgZBBCjVhcp6yodmgCXUjNVV8UYokZHP1+kjUpUcTl37+e0O/zQK4h1XAv+oNTTg==", "license": "MIT", "dependencies": { "@doist/sdk-kmp": "0.5.0", diff --git a/package.json b/package.json index 9e697cbb..38f5ad4e 100644 --- a/package.json +++ b/package.json @@ -53,7 +53,7 @@ ], "dependencies": { "@doist/cli-core": "1.7.0", - "@doist/todoist-sdk": "15.7.0", + "@doist/todoist-sdk": "15.8.0", "@napi-rs/keyring": "2.1.1", "@pnpm/tabtab": "0.5.4", "chalk": "6.0.1", diff --git a/src/lib/api/filters.ts b/src/lib/api/filters.ts index daa12ae7..605d1da0 100644 --- a/src/lib/api/filters.ts +++ b/src/lib/api/filters.ts @@ -84,7 +84,5 @@ export async function updateFilter(id: string, args: UpdateFilterArgs): Promise< export async function deleteFilter(id: string): Promise { const api = await getApi() - await api.sync({ - commands: [createCommand('filter_delete', { id })], - }) + await api.deleteFilter(id) } From ee8486b7afd44c5da75ad90322550de2dd04737a Mon Sep 17 00:00:00 2001 From: Scott Lovegrove Date: Fri, 23 Oct 2026 11:45:31 +0100 Subject: [PATCH 2/2] test: cover the REST filter delete and show its spinner Add a test that `deleteFilter` calls the SDK's REST `deleteFilter()` and sends no Sync command, stub `deleteFilter` in the shared API mock, and give it a "Deleting filter..." spinner like the other deletes. --- src/lib/api/core.ts | 2 ++ src/lib/api/filters.test.ts | 25 +++++++++++++++++++++++++ src/test-support/mock-api.ts | 2 ++ 3 files changed, 29 insertions(+) create mode 100644 src/lib/api/filters.test.ts diff --git a/src/lib/api/core.ts b/src/lib/api/core.ts index ec49cef4..b2e97e0e 100644 --- a/src/lib/api/core.ts +++ b/src/lib/api/core.ts @@ -124,6 +124,8 @@ const API_SPINNER_MESSAGES: Record ({ + getApi: vi.fn(), +})) + +import { setupApiMock } from '../../test-support/api-mock.js' +import type { MockApi } from '../../test-support/mock-api.js' +import { deleteFilter } from './filters.js' + +describe('deleteFilter', () => { + let mockApi: MockApi + + beforeEach(() => { + vi.clearAllMocks() + mockApi = setupApiMock() + }) + + it('deletes the filter through the REST endpoint', async () => { + await deleteFilter('filter-123') + + expect(mockApi.deleteFilter).toHaveBeenCalledWith('filter-123') + expect(mockApi.sync).not.toHaveBeenCalled() + }) +}) diff --git a/src/test-support/mock-api.ts b/src/test-support/mock-api.ts index 36b3bdc4..5d1b5c1f 100644 --- a/src/test-support/mock-api.ts +++ b/src/test-support/mock-api.ts @@ -210,6 +210,8 @@ export function createMockApi(overrides: Partial = {}): MockApi { addFolder: vi.fn(), updateFolder: vi.fn(), deleteFolder: vi.fn().mockResolvedValue(true), + // Filters + deleteFilter: vi.fn().mockResolvedValue(true), ...overrides, } as unknown as MockApi }