From 4d8540fbd23a1aec492944aef4927e781270779b Mon Sep 17 00:00:00 2001 From: Aakash Ashok Naik <91958822+naik-aakash@users.noreply.github.com> Date: Mon, 5 Jan 2026 08:56:45 +0000 Subject: [PATCH 1/3] fix cli inconsistency with noisecutoff parameter --- src/lobsterpy/cli.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lobsterpy/cli.py b/src/lobsterpy/cli.py index 416271a6..93d1f77e 100644 --- a/src/lobsterpy/cli.py +++ b/src/lobsterpy/cli.py @@ -413,7 +413,7 @@ def get_parser() -> argparse.ArgumentParser: auto_group.add_argument( "--noisecutoff", type=float, - default=None, + default=0.1, help="Sets the lower limit of icohps or icoops or icobis considered in automatic analysis", ) auto_group.add_argument( From 048dba9ca0f0ccb1a6e3637c2ab2d19def0f2884 Mon Sep 17 00:00:00 2001 From: Aakash Ashok Naik <91958822+naik-aakash@users.noreply.github.com> Date: Mon, 5 Jan 2026 08:56:55 +0000 Subject: [PATCH 2/3] adapt test --- tests/cli/test_cli.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cli/test_cli.py b/tests/cli/test_cli.py index 67789a5d..f8c4e68d 100644 --- a/tests/cli/test_cli.py +++ b/tests/cli/test_cli.py @@ -197,6 +197,8 @@ def test_cli_interactive_plotter_coops(self, tmp_path): "--hideplot", "--coops", "--allbonds", + "--noisecutoff", + "0.001" ] test = get_parser().parse_args(args) run(test) From 9f3c30e0b6244f1b5323a3790fe46e13f57d39da Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 5 Jan 2026 09:00:06 +0000 Subject: [PATCH 3/3] pre-commit auto-fixes --- tests/cli/test_cli.py | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/tests/cli/test_cli.py b/tests/cli/test_cli.py index f8c4e68d..995dda4c 100644 --- a/tests/cli/test_cli.py +++ b/tests/cli/test_cli.py @@ -191,15 +191,7 @@ def test_cli_interactive_plotter_cobi(self): def test_cli_interactive_plotter_coops(self, tmp_path): os.chdir(TestDir / "test_data/CdF_comp_range") # tests skip showing plots generated using automatic interactive plotter - args = [ - "auto-plot-ia", - "--orbitalresolved", - "--hideplot", - "--coops", - "--allbonds", - "--noisecutoff", - "0.001" - ] + args = ["auto-plot-ia", "--orbitalresolved", "--hideplot", "--coops", "--allbonds", "--noisecutoff", "0.001"] test = get_parser().parse_args(args) run(test)