diff --git a/packages/devextreme/js/__internal/scheduler/__tests__/appointments_new.test.ts b/packages/devextreme/js/__internal/scheduler/__tests__/appointments_new.test.ts index ba81f77f6b1c..7ebc570c4518 100644 --- a/packages/devextreme/js/__internal/scheduler/__tests__/appointments_new.test.ts +++ b/packages/devextreme/js/__internal/scheduler/__tests__/appointments_new.test.ts @@ -4,6 +4,7 @@ import { import type { dxElementWrapper } from '@js/core/renderer'; import $ from '@js/core/renderer'; import type { Properties } from '@js/ui/scheduler'; +import { fireEvent } from '@testing-library/dom'; import { createScheduler as baseCreateScheduler } from './__mock__/create_scheduler'; import { setupSchedulerTestEnvironment } from './__mock__/m_mock_scheduler'; @@ -756,4 +757,88 @@ describe('New Appointments', () => { expect(appointment.text).toBe('Updated Appointment'); }); }); + + describe('Keyboard navigation', () => { + it('should delete appointment by delete key', async () => { + const { POM } = await createScheduler({ + dataSource: [{ + startDate: new Date(2015, 1, 9, 8), + endDate: new Date(2015, 1, 9, 9), + }], + currentDate: new Date(2015, 1, 9, 8), + }); + + const appointment = POM.getAppointments()[0]; + appointment.element.focus(); + fireEvent.keyDown(appointment.element, { key: 'Delete' }); + await new Promise(process.nextTick); + + expect(POM.getAppointments().length).toBe(0); + }); + + it('should delete recurring appointment occurrence by delete key', async () => { + const { POM } = await createScheduler({ + dataSource: [{ + startDate: new Date(2015, 1, 9, 8), + endDate: new Date(2015, 1, 9, 9), + recurrenceRule: 'FREQ=DAILY;COUNT=3', + }], + currentDate: new Date(2015, 1, 9), + currentView: 'week', + recurrenceEditMode: 'occurrence', + }); + + expect(POM.getAppointments().length).toBe(3); + + const appointment = POM.getAppointments()[0]; + appointment.element.focus(); + fireEvent.keyDown(appointment.element, { key: 'Delete' }); + await new Promise(process.nextTick); + + expect(POM.getAppointments().length).toBe(2); + }); + + it.each([ + { editing: true }, + { editing: { allowDeleting: true } }, + { editing: { allowDeleting: true, allowUpdating: false } }, + ])('should delete appointment when editing=$editing', async ({ editing }) => { + const { POM } = await createScheduler({ + dataSource: [{ + startDate: new Date(2015, 1, 9, 8), + endDate: new Date(2015, 1, 9, 9), + }], + currentDate: new Date(2015, 1, 9, 8), + editing, + }); + + const appointment = POM.getAppointments()[0]; + appointment.element.focus(); + fireEvent.keyDown(appointment.element, { key: 'Delete' }); + await new Promise(process.nextTick); + + expect(POM.getAppointments().length).toBe(0); + }); + + it.each([ + { editing: { allowDeleting: false } }, + { editing: false }, + ])('should NOT delete appointment when editing=$editing', async ({ editing }) => { + const { POM } = await createScheduler({ + dataSource: [{ + startDate: new Date(2015, 1, 9, 8), + endDate: new Date(2015, 1, 9, 9), + }], + currentDate: new Date(2015, 1, 9, 8), + editing, + }); + + const appointment = POM.getAppointments()[0]; + appointment.element.focus(); + fireEvent.keyDown(appointment.element, { key: 'Delete' }); + await new Promise(process.nextTick); + + expect(POM.getAppointments().length).toBe(1); + }); + }); }); diff --git a/packages/devextreme/js/__internal/scheduler/appointments_new/appointment/base_appointment.ts b/packages/devextreme/js/__internal/scheduler/appointments_new/appointment/base_appointment.ts index 782f8a87be0a..50583424a003 100644 --- a/packages/devextreme/js/__internal/scheduler/appointments_new/appointment/base_appointment.ts +++ b/packages/devextreme/js/__internal/scheduler/appointments_new/appointment/base_appointment.ts @@ -38,11 +38,11 @@ export interface BaseAppointmentViewProperties export class BaseAppointmentView< TProperties extends BaseAppointmentViewProperties = BaseAppointmentViewProperties, > extends ViewItem { - get targetedAppointmentData(): TargetedAppointment { + public get targetedAppointmentData(): TargetedAppointment { return this.option().targetedAppointmentData; } - get appointmentData(): SafeAppointment { + public get appointmentData(): SafeAppointment { return this.option().appointmentData; } diff --git a/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.focus_controller.ts b/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.focus_controller.ts index fafa90451a22..4a974c474540 100644 --- a/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.focus_controller.ts +++ b/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.focus_controller.ts @@ -5,16 +5,22 @@ import { focus } from '@ts/events/m_short'; import { getRawAppointmentGroupValues } from '../utils/resource_manager/appointment_groups_utils'; import type { SortedEntity } from '../view_model/types'; +import type { BaseAppointmentView } from './appointment/base_appointment'; +import { AppointmentCollector } from './appointment_collector'; import type { Appointments } from './appointments'; import type { ViewItem } from './view_item'; +interface AppointmentsFocusControllerHandlers { + onAppointmentEnterKeyDown: (appointmentView: BaseAppointmentView, event: DxEvent) => void; +} + export class AppointmentsFocusController { private focusableSortedIndex = 0; private needRestoreFocusIndex = -1; - private get sortedAppointments(): SortedEntity[] { - return this.appointments.option().getSortedAppointments(); + private get sortedItems(): SortedEntity[] { + return this.appointments.option().getSortedItems(); } private get isVirtualScrolling(): boolean { @@ -25,7 +31,10 @@ export class AppointmentsFocusController { return this.appointments.option().tabIndex; } - constructor(private readonly appointments: Appointments) { } + constructor( + private readonly appointments: Appointments, + private readonly handlers: AppointmentsFocusControllerHandlers, + ) { } public onViewItemClick(viewItem: ViewItem): void { this.focusViewItem(viewItem); @@ -50,8 +59,27 @@ export class AppointmentsFocusController { } public onViewItemKeyDown(viewItem: ViewItem, e: KeyboardKeyDownEvent): void { - if (e.key === 'Tab') { - this.handleTabKeyDown(e, viewItem.option().sortedIndex); + switch (true) { + case e.key === 'Tab': + this.handleTabKeyDown(e, viewItem.option().sortedIndex); + break; + case e.key === 'Delete': + this.handleDeleteKeyDown(viewItem); + break; + case e.key === 'Home': + this.handleHomeKeyDown(e); + break; + case e.key === 'End': + this.handleEndKeyDown(e); + break; + case e.key === 'Enter': + this.handleEnterKeyDown(viewItem, e); + break; + case e.key === ' ': + this.handleEnterKeyDown(viewItem, e); + break; + default: + break; } } @@ -82,27 +110,69 @@ export class AppointmentsFocusController { private handleTabKeyDown(e: KeyboardKeyDownEvent, sortedIndex: number): void { const nextIndex = sortedIndex + (e.shift ? -1 : 1); - const nextItemData = this.sortedAppointments[nextIndex]; + const nextItemData = this.sortedItems[nextIndex]; if (!nextItemData) { return; } e.originalEvent.preventDefault(); - this.focusByItemData(nextItemData); + this.focusBySortedItem(nextItemData); + } + + private handleDeleteKeyDown(viewItem: ViewItem): void { + if (viewItem instanceof AppointmentCollector) { return; } + + const { allowDelete, onDeleteKeyPress } = this.appointments.option(); + if (!allowDelete) { return; } + + const appointmentViewItem = viewItem as BaseAppointmentView; + onDeleteKeyPress({ + appointmentData: appointmentViewItem.appointmentData, + targetedAppointmentData: appointmentViewItem.targetedAppointmentData, + }); + } + + private handleHomeKeyDown(e: KeyboardKeyDownEvent): void { + const firstSortedItem = this.sortedItems[0]; + if (firstSortedItem) { + e.originalEvent.preventDefault(); + this.focusBySortedItem(firstSortedItem); + } + } + + private handleEndKeyDown(e: KeyboardKeyDownEvent): void { + const lastSortedItem = this.sortedItems[this.sortedItems.length - 1]; + if (lastSortedItem) { + e.originalEvent.preventDefault(); + this.focusBySortedItem(lastSortedItem); + } + } + + private handleEnterKeyDown(viewItem: ViewItem, e: KeyboardKeyDownEvent): void { + e.originalEvent.preventDefault(); + + if (viewItem instanceof AppointmentCollector) { + return; + } + + this.handlers.onAppointmentEnterKeyDown( + viewItem as BaseAppointmentView, + e.originalEvent as DxEvent, + ); } - private focusByItemData(itemData: SortedEntity): void { + private focusBySortedItem(sortedItem: SortedEntity): void { if (this.isVirtualScrolling) { - this.scrollToItem(itemData); + this.scrollToItem(sortedItem); } - const viewItem = this.appointments.getViewItemBySortedIndex(itemData.sortedIndex); + const viewItem = this.appointments.getViewItemBySortedIndex(sortedItem.sortedIndex); if (viewItem) { this.focusViewItem(viewItem); } else if (this.isVirtualScrolling) { - this.needRestoreFocusIndex = itemData.sortedIndex; + this.needRestoreFocusIndex = sortedItem.sortedIndex; } } @@ -111,19 +181,19 @@ export class AppointmentsFocusController { focus.trigger(viewItem?.$element()); } - private scrollToItem(itemData: SortedEntity): void { + private scrollToItem(sortedItem: SortedEntity): void { const { getStartViewDate, getResourceManager, scrollTo } = this.appointments.option(); const date = new Date(Math.max( getStartViewDate().getTime(), - itemData.source.startDate, + sortedItem.source.startDate, )); const group = getRawAppointmentGroupValues( - itemData.itemData, + sortedItem.itemData, getResourceManager().resources, ); - scrollTo(date, { group, allDay: itemData.allDay }); + scrollTo(date, { group, allDay: sortedItem.allDay }); } } diff --git a/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.test.ts b/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.test.ts index a188e935e645..4cab9eee32f2 100644 --- a/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.test.ts +++ b/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.test.ts @@ -4,7 +4,6 @@ import { import $ from '@js/core/renderer'; import { fireEvent } from '@testing-library/dom'; -import fx from '../../../common/core/animation/fx'; import { mockAppointmentDataAccessor } from '../__mock__/appointment_data_accessor.mock'; import { getResourceManagerMock } from '../__mock__/resource_manager.mock'; import type { ResourceConfig } from '../utils/loader/types'; @@ -44,7 +43,7 @@ const getProperties = (options: { onAppointmentDblClick: (): void => {}, getStartViewDate: () => new Date(2024, 0, 1), - getSortedAppointments: () => [], + getSortedItems: () => [], isVirtualScrolling: () => false, scrollTo: (): void => {}, @@ -55,6 +54,8 @@ const getProperties = (options: { showTooltipForAppointment: (): void => {}, showTooltipForCollector: (): void => {}, showEditAppointmentPopup: (): void => {}, + allowDelete: false, + onDeleteKeyPress: (): void => {}, }); const createAppointments = ( @@ -80,8 +81,6 @@ const dblClick = (element: HTMLElement): void => { describe('Appointments', () => { beforeEach(() => { - fx.off = true; - const $container = $('
') .addClass('container') .appendTo(document.body); @@ -97,8 +96,6 @@ describe('Appointments', () => { afterEach(() => { $('.container').remove(); - fx.off = false; - jest.useRealTimers(); }); describe('Classes', () => { @@ -553,7 +550,7 @@ describe('Appointments', () => { const instance = createAppointments({ ...getProperties(), - getSortedAppointments: () => viewModel as unknown as SortedEntity[], + getSortedItems: () => viewModel as unknown as SortedEntity[], }); instance.option('viewModel', viewModel); @@ -561,9 +558,7 @@ describe('Appointments', () => { const viewItem1 = instance.getViewItemBySortedIndex(1); (viewItem0?.$element().get(0) as HTMLElement).click(); - viewItem0?.$element().get(0).dispatchEvent( - new KeyboardEvent('keydown', { key: 'Tab', bubbles: true }), - ); + fireEvent.keyDown(viewItem0?.$element().get(0) as HTMLElement, { key: 'Tab' }); expect(viewItem0?.$element().attr('tabindex')).toBe('-1'); expect(viewItem1?.$element().attr('tabindex')).toBe('0'); @@ -579,7 +574,7 @@ describe('Appointments', () => { const instance = createAppointments({ ...getProperties(), - getSortedAppointments: () => viewModel as unknown as SortedEntity[], + getSortedItems: () => viewModel as unknown as SortedEntity[], }); instance.option('viewModel', viewModel); @@ -587,9 +582,7 @@ describe('Appointments', () => { const viewItem1 = instance.getViewItemBySortedIndex(1); (viewItem1?.$element().get(0) as HTMLElement).click(); - viewItem1?.$element().get(0).dispatchEvent( - new KeyboardEvent('keydown', { key: 'Tab', shiftKey: true, bubbles: true }), - ); + fireEvent.keyDown(viewItem1?.$element().get(0) as HTMLElement, { key: 'Tab', shiftKey: true }); expect(viewItem0?.$element().attr('tabindex')).toBe('0'); expect(viewItem1?.$element().attr('tabindex')).toBe('-1'); @@ -650,7 +643,7 @@ describe('Appointments', () => { ...getProperties(), isVirtualScrolling: () => true, scrollTo, - getSortedAppointments: () => [ + getSortedItems: () => [ makeSortedEntity(0), makeSortedEntity(1), makeSortedEntity(1), ], }); @@ -661,9 +654,7 @@ describe('Appointments', () => { const viewItem1 = instance.getViewItemBySortedIndex(0); (viewItem1?.$element().get(0) as HTMLElement).click(); - viewItem1?.$element().get(0).dispatchEvent( - new KeyboardEvent('keydown', { key: 'Tab', bubbles: true }), - ); + fireEvent.keyDown(viewItem1?.$element().get(0) as HTMLElement, { key: 'Tab' }); expect(scrollTo).toHaveBeenCalled(); }); @@ -672,7 +663,7 @@ describe('Appointments', () => { const instance = createAppointments({ ...getProperties(), isVirtualScrolling: () => true, - getSortedAppointments: () => [ + getSortedItems: () => [ makeSortedEntity(0), makeSortedEntity(1), makeSortedEntity(2), ], }); @@ -686,9 +677,7 @@ describe('Appointments', () => { const viewItem2 = instance.getViewItemBySortedIndex(2); (viewItem1?.$element().get(0) as HTMLElement).click(); - viewItem1?.$element().get(0).dispatchEvent( - new KeyboardEvent('keydown', { key: 'Tab', bubbles: true }), - ); + fireEvent.keyDown(viewItem1?.$element().get(0) as HTMLElement, { key: 'Tab' }); expect(document.activeElement).toBe(viewItem2?.$element().get(0)); }); @@ -701,7 +690,7 @@ describe('Appointments', () => { const instance = createAppointments({ ...getProperties(), isVirtualScrolling: () => true, - getSortedAppointments: () => [ + getSortedItems: () => [ makeSortedEntity(0), makeSortedEntity(1), makeSortedEntity(2), ], }); @@ -711,9 +700,7 @@ describe('Appointments', () => { const viewItem1 = instance.getViewItemBySortedIndex(1); (viewItem1?.$element().get(0) as HTMLElement).click(); - viewItem1?.$element().get(0).dispatchEvent( - new KeyboardEvent('keydown', { key: 'Tab', bubbles: true }), - ); + fireEvent.keyDown(viewItem1?.$element().get(0) as HTMLElement, { key: 'Tab' }); // item2 is not rendered yet, so focus cannot move yet expect(instance.getViewItemBySortedIndex(2)).toBeUndefined(); @@ -737,7 +724,7 @@ describe('Appointments', () => { isVirtualScrolling: () => true, scrollTo, getStartViewDate: () => startViewDate, - getSortedAppointments: () => [ + getSortedItems: () => [ makeSortedEntity(0), makeSortedEntity(1, appointmentStartDate), ], }); @@ -747,9 +734,7 @@ describe('Appointments', () => { const viewItem0 = instance.getViewItemBySortedIndex(0); (viewItem0?.$element().get(0) as HTMLElement).click(); - viewItem0?.$element().get(0).dispatchEvent( - new KeyboardEvent('keydown', { key: 'Tab', bubbles: true }), - ); + fireEvent.keyDown(viewItem0?.$element().get(0) as HTMLElement, { key: 'Tab' }); expect(scrollTo).toHaveBeenCalledWith(appointmentStartDate, expect.anything()); }); @@ -767,15 +752,13 @@ describe('Appointments', () => { isVirtualScrolling: () => true, scrollTo, getStartViewDate: () => startViewDate, - getSortedAppointments: () => sortedEntities, + getSortedItems: () => sortedEntities, }); instance.option('viewModel', viewModel); const viewItem0 = instance.getViewItemBySortedIndex(0); (viewItem0?.$element().get(0) as HTMLElement).click(); - viewItem0?.$element().get(0).dispatchEvent( - new KeyboardEvent('keydown', { key: 'Tab', bubbles: true }), - ); + fireEvent.keyDown(viewItem0?.$element().get(0) as HTMLElement, { key: 'Tab' }); expect(scrollTo).toHaveBeenCalledWith(startViewDate, expect.anything()); }); @@ -784,9 +767,7 @@ describe('Appointments', () => { describe('Navigation after partial render', () => { const pressTab = (): void => { const activeElement = document.activeElement as HTMLElement; - activeElement.dispatchEvent( - new KeyboardEvent('keydown', { key: 'Tab', bubbles: true }), - ); + fireEvent.keyDown(activeElement, { key: 'Tab' }); }; it('should navigate to the last appointment correctly after an appointment is added', () => { @@ -802,7 +783,7 @@ describe('Appointments', () => { const instance = createAppointments({ ...getProperties(), - getSortedAppointments: () => viewModel as unknown as SortedEntity[], + getSortedItems: () => viewModel as unknown as SortedEntity[], }); instance.option('viewModel', viewModel); @@ -838,7 +819,7 @@ describe('Appointments', () => { const instance = createAppointments({ ...getProperties(), - getSortedAppointments: () => viewModel as unknown as SortedEntity[], + getSortedItems: () => viewModel as unknown as SortedEntity[], }); instance.option('viewModel', viewModel); @@ -870,7 +851,7 @@ describe('Appointments', () => { const instance = createAppointments({ ...getProperties(), - getSortedAppointments: () => viewModel as unknown as SortedEntity[], + getSortedItems: () => viewModel as unknown as SortedEntity[], }); instance.option('viewModel', viewModel); @@ -891,6 +872,349 @@ describe('Appointments', () => { expect(lastViewItem?.$element().attr('tabindex')).toBe('0'); }); }); + + describe('Home/End navigation', () => { + it('should move focus to first appointment on Home key', () => { + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 1 }), + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 2 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + getSortedItems: () => viewModel as unknown as SortedEntity[], + }); + instance.option('viewModel', viewModel); + + const viewItem0 = instance.getViewItemBySortedIndex(0); + const viewItem2 = instance.getViewItemBySortedIndex(2); + + (viewItem2?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem2?.$element().get(0) as HTMLElement, { key: 'Home' }); + + expect(viewItem0?.$element().attr('tabindex')).toBe('0'); + expect(viewItem2?.$element().attr('tabindex')).toBe('-1'); + expect(document.activeElement).toBe(viewItem0?.$element().get(0)); + }); + + it('should prevent default browser behavior on Home key', () => { + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 1 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + getSortedItems: () => viewModel as unknown as SortedEntity[], + }); + instance.option('viewModel', viewModel); + + const viewItem1 = instance.getViewItemBySortedIndex(1); + (viewItem1?.$element().get(0) as HTMLElement).click(); + + const wasDefaultPrevented = !fireEvent.keyDown( + viewItem1?.$element().get(0) as HTMLElement, + { key: 'Home' }, + ); + + expect(wasDefaultPrevented).toBe(true); + }); + + it('should prevent default browser behavior on End key', () => { + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 1 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + getSortedItems: () => viewModel as unknown as SortedEntity[], + }); + instance.option('viewModel', viewModel); + + const viewItem0 = instance.getViewItemBySortedIndex(0); + (viewItem0?.$element().get(0) as HTMLElement).click(); + + const wasDefaultPrevented = !fireEvent.keyDown( + viewItem0?.$element().get(0) as HTMLElement, + { key: 'End' }, + ); + + expect(wasDefaultPrevented).toBe(true); + }); + + it('should prevent default browser behavior on Enter key', () => { + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + + const wasDefaultPrevented = !fireEvent.keyDown( + viewItem?.$element().get(0) as HTMLElement, + { key: 'Enter' }, + ); + + expect(wasDefaultPrevented).toBe(true); + }); + + it('should prevent default browser behavior on Space key', () => { + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + + const wasDefaultPrevented = !fireEvent.keyDown( + viewItem?.$element().get(0) as HTMLElement, + { key: ' ' }, + ); + + expect(wasDefaultPrevented).toBe(true); + }); + + it('should move focus to last appointment on End key', () => { + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 1 }), + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 2 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + getSortedItems: () => viewModel as unknown as SortedEntity[], + }); + instance.option('viewModel', viewModel); + + const viewItem0 = instance.getViewItemBySortedIndex(0); + const viewItem2 = instance.getViewItemBySortedIndex(2); + + (viewItem0?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem0?.$element().get(0) as HTMLElement, { key: 'End' }); + + expect(viewItem2?.$element().attr('tabindex')).toBe('0'); + expect(viewItem0?.$element().attr('tabindex')).toBe('-1'); + expect(document.activeElement).toBe(viewItem2?.$element().get(0)); + }); + }); + + describe('Keyboard actions', () => { + it('should call onDeleteKeyPress when Delete is pressed and allowDelete is true', () => { + const onDeleteKeyPress = jest.fn(); + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 1 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + allowDelete: true, + onDeleteKeyPress, + getSortedItems: () => [{ + sortedIndex: 0, + itemData: defaultAppointmentData, + source: { startDate: 0 }, + }] as unknown as SortedEntity[], + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: 'Delete' }); + + expect(onDeleteKeyPress).toHaveBeenCalledTimes(1); + expect(onDeleteKeyPress).toHaveBeenCalledWith( + expect.objectContaining({ appointmentData: defaultAppointmentData }), + ); + }); + + it('should not call onDeleteKeyPress when Delete is pressed and allowDelete is false', () => { + const onDeleteKeyPress = jest.fn(); + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + allowDelete: false, + onDeleteKeyPress, + getSortedItems: () => viewModel as unknown as SortedEntity[], + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: 'Delete' }); + + expect(onDeleteKeyPress).not.toHaveBeenCalled(); + }); + + it('should not call onDeleteKeyPress when Delete is pressed on appointment collector', () => { + const onDeleteKeyPress = jest.fn(); + const viewModel = [ + mockAppointmentCollectorViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + allowDelete: true, + onDeleteKeyPress, + getSortedItems: () => viewModel as unknown as SortedEntity[], + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: 'Delete' }); + + expect(onDeleteKeyPress).not.toHaveBeenCalled(); + }); + + it('should show appointment popup when Enter is pressed', () => { + const showEditAppointmentPopup = jest.fn(); + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + showEditAppointmentPopup, + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: 'Enter' }); + + expect(showEditAppointmentPopup).toHaveBeenCalledTimes(1); + expect(showEditAppointmentPopup).toHaveBeenCalledWith( + defaultAppointmentData, + expect.objectContaining({ ...defaultAppointmentData }), + ); + }); + + it('should call onAppointmentDblClick when Enter is pressed', () => { + const onAppointmentDblClick = jest.fn(); + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + onAppointmentDblClick, + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: 'Enter' }); + + expect(onAppointmentDblClick).toHaveBeenCalledTimes(1); + expect(onAppointmentDblClick).toHaveBeenCalledWith( + expect.objectContaining({ appointmentData: defaultAppointmentData }), + ); + }); + + it('should show appointment popup when Space is pressed', () => { + const showEditAppointmentPopup = jest.fn(); + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + showEditAppointmentPopup, + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: ' ' }); + + expect(showEditAppointmentPopup).toHaveBeenCalledTimes(1); + expect(showEditAppointmentPopup).toHaveBeenCalledWith( + defaultAppointmentData, + expect.objectContaining({ ...defaultAppointmentData }), + ); + }); + + it('should call onAppointmentDblClick when Space is pressed', () => { + const onAppointmentDblClick = jest.fn(); + const viewModel = [ + mockGridViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + onAppointmentDblClick, + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + (viewItem?.$element().get(0) as HTMLElement).click(); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: ' ' }); + + expect(onAppointmentDblClick).toHaveBeenCalledTimes(1); + expect(onAppointmentDblClick).toHaveBeenCalledWith( + expect.objectContaining({ appointmentData: defaultAppointmentData }), + ); + }); + + it('should show tooltip when Enter is pressed on appointment collector', () => { + const showTooltipForCollector = jest.fn(); + const showEditAppointmentPopup = jest.fn(); + const viewModel = [ + mockAppointmentCollectorViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + showTooltipForCollector, + showEditAppointmentPopup, + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: 'Enter' }); + + expect(showTooltipForCollector).toHaveBeenCalledTimes(1); + expect(showEditAppointmentPopup).not.toHaveBeenCalled(); + }); + + it('should show tooltip when Space is pressed on appointment collector', () => { + const showTooltipForCollector = jest.fn(); + const showEditAppointmentPopup = jest.fn(); + const viewModel = [ + mockAppointmentCollectorViewModel({ ...defaultAppointmentData }, { sortedIndex: 0 }), + ]; + + const instance = createAppointments({ + ...getProperties(), + showTooltipForCollector, + showEditAppointmentPopup, + }); + instance.option('viewModel', viewModel); + + const viewItem = instance.getViewItemBySortedIndex(0); + fireEvent.keyDown(viewItem?.$element().get(0) as HTMLElement, { key: ' ' }); + + expect(showTooltipForCollector).toHaveBeenCalledTimes(1); + expect(showEditAppointmentPopup).not.toHaveBeenCalled(); + }); + }); }); describe('onAppointmentRendered', () => { diff --git a/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.ts b/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.ts index 484b6f8c88a9..5b726c43118a 100644 --- a/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.ts +++ b/packages/devextreme/js/__internal/scheduler/appointments_new/appointments.ts @@ -64,7 +64,7 @@ export interface AppointmentsProperties extends DOMComponentProperties ResourceManager; getDataAccessor: () => AppointmentDataAccessor; getStartViewDate: () => Date; - getSortedAppointments: () => SortedEntity[]; + getSortedItems: () => SortedEntity[]; isVirtualScrolling: () => boolean; scrollTo: (date: Date, options?: ScrollToOptions) => void; @@ -82,6 +82,12 @@ export interface AppointmentsProperties extends DOMComponentProperties void; + + allowDelete: boolean; + onDeleteKeyPress: (options: { + appointmentData: SafeAppointment; + targetedAppointmentData: TargetedAppointment; + }) => void; } export class Appointments extends DOMComponent { @@ -112,7 +118,9 @@ export class Appointments extends DOMComponent = { tabIndex: this.option('tabIndex'), currentView: this.option('currentView') as ViewType, + allowDelete: this.editing.allowDeleting, appointmentTemplate: this.getViewOption('appointmentTemplate'), appointmentCollectorTemplate: this.getViewOption('appointmentCollectorTemplate'), onAppointmentRendered: (...args) => this.actions.onAppointmentRendered(...args), onAppointmentClick: (...args) => this.actions.onAppointmentClick(...args), onAppointmentDblClick: (...args) => this.actions.onAppointmentDblClick(...args), + onDeleteKeyPress: (e) => { + this.checkAndDeleteAppointment(e.appointmentData, e.targetedAppointmentData); + }, getResourceManager: () => this.resourceManager, getAppointmentDataSource: () => this.appointmentDataSource, getDataAccessor: () => this._dataAccessors, getStartViewDate: () => this.getStartViewDate(), - getSortedAppointments: () => this._layoutManager.sortedItems, + getSortedItems: () => this._layoutManager.sortedItems, + isVirtualScrolling: () => this.isVirtualScrolling(), scrollTo: this.scrollTo.bind(this), @@ -1242,7 +1251,6 @@ class Scheduler extends SchedulerOptionsBaseWidget { targetedAppointment, this._dataAccessors, ); - const deletingOptions = this.fireOnAppointmentDeleting(appointment, targetedAdapter); this.checkRecurringAppointment( appointment,