Stabilize required-file upload regression coverage after Task link save

[alexeygrigorev]

Stabilize required-file upload regression coverage after Task link save

Status: blocked for coordinated release — Tester PASS and PM ACCEPTED; exact commit 7564688 is in local main ancestry, held and unpushed; no shipped/deployed claim
Tags: bug, frontend, testing, P1
Depends on: #217 preview/deployment/post-deployment identity gate for coordinated publication
Blocks: None
Next owner: Orchestrator after #217 release/identity PASS, for safe coordinated push; then On-Call
Resume condition: #217 completes its HUMAN preview, ordinary main/OIDC deployment, terminal On-Call result, and HUMAN identity verification; then publish the exact accepted #216 content through the safe coordinated release lineage.

Scope

At main commit 7d77632, the real-server regression journey in backend/e2e/canonical-task-workflow-behavior.spec.js waits for the versioned Task-link PUT response and immediately calls Playwright setInputFiles. The existing frontend contract intentionally keeps the Task mutation busy through the authoritative refresh: it renders Saving Task link… and disables the required-file input. The early Playwright call can therefore change the browser file value without starting POST /work/api/files.

Make the smallest test-only synchronization and diagnostic change. The regression test must wait for observable authoritative completion of the existing link-save flow (success feedback/refresh and an enabled file input, or equivalent authoritative UI evidence) before setting the file. It must also assert that the file input is disabled while the link mutation is pending and that the upload POST starts only after the link save has settled.

A focused local real-server probe is required during implementation: with the unchanged production code and the corrected wait, the required file must upload successfully and render in the Task panel. If that probe fails after the correct wait, stop and re-groom this issue for a production defect; do not paper over it in the test.

Preserve versioned link saving, authoritative refresh, mutation ownership/focus behavior, required-file completion gating, synthetic-only fixtures, and the existing no-shim/public-data boundaries.

Acceptance Criteria

• The committed diff is limited to the canonical regression test and narrowly necessary test diagnostics/helpers; no production frontend, backend runtime, infrastructure, AWS, or provider files are changed.
• The test proves the pending contract: after link blur starts the PUT, Saving Task link… is observable, the required-file input is disabled, and no POST /work/api/files is attempted.
• The test waits for the existing authoritative success/refresh state, then proves the file input is enabled, exactly one POST /work/api/files succeeds, the file row appears, and required-file completion becomes enabled.
• The existing version assertion, conflict/recovery path, durable completion, reload persistence, and browser-error checks remain passing.
• Evidence is synthetic and local only. No AWS/provider calls, infrastructure edits, deployment, production writes, compatibility shim, alternate route, or production behavior change is introduced.
• Tester captures and inspects screenshots for the pending-disabled and saved/uploaded states under .tmp/screenshots/issue-216/; the screenshots must show no error page, overlap, or missing state.
• Before handoff, the final worktree is clean and the handoff records the exact final-tree fingerprint command and output.

Test Scenarios

Scenario: Pending Task-link save gates the file control

Given: A synthetic required-file Task is open in the canonical real-server Task panel.
When: The operator fills the required link and blurs it while observing the link PUT.
Then: The PUT contains the expected version and returns 200; while the mutation is pending, Saving Task link… is visible, the file input is disabled, and no file-upload POST occurs.

Scenario: Authoritative refresh unlocks the upload

Given: The link PUT has returned 200 and the existing authoritative Task refresh has completed.
When: The test confirms the success feedback/enabled input and selects one synthetic file.
Then: Exactly one POST /work/api/files returns the expected success status, the file appears in .task-file-item, and Mark done is enabled without unexpected browser errors.

Scenario: Existing proof lifecycle remains intact

Given: The file and link are present.
When: The test exercises the existing synthetic conflict, retry, completion, reload, and persistence path.
Then: Version checks, conflict feedback, completion, and reloaded proof state remain correct.

Out of Scope

• Any change to production frontend/src/ or backend/src/ behavior.
• Replacing the existing mutation-busy, disabled-input, authoritative-refresh, focus, or completion-gating contract.
• New API routes, upload semantics, retries, polling, delays, sleeps, compatibility shims, aliases, or dual-read/write behavior.
• Real accounts, AWS/providers, infrastructure/templates, deployment, production data, or source repositories.
• Broad unrelated E2E cleanup or changes to the Home, Docs, or other portal surfaces.

Dependencies

• None. The source diagnosis and required production contract are present at 7d77632.
• The Software Engineer must work in an isolated worktree and must not commit until Tester PASS and PM acceptance.
• Required verification commands:

  node --test frontend/test/work-detail-surface.test.mjs
  npm run test:frontend:unit
  npm --prefix backend run typecheck
  npm --prefix backend test
  CI= DATAOPS_E2E_SERVER_PORT=45162 npx playwright test backend/e2e/canonical-task-workflow-behavior.spec.js --grep "Required proof saves one versioned link, file, conflict, and durable completion" --retries=0 --reporter=line
  npm --prefix backend run test:e2e
  git diff --check

• Final-tree fingerprint requirement:

  test -z "$(git status --porcelain=v1 --untracked-files=all)" && git diff --exit-code && git diff --cached --exit-code && git rev-parse HEAD && git ls-tree -r --full-tree HEAD | sha256sum

  The handoff must include the empty status/diff result, commit SHA, and tree SHA-256.

[alexeygrigorev]

PM GROOMED

The issue is agent-ready: it scopes a test-only synchronization of the canonical required-file journey to the rendered authoritative Task-link success/ready state, preserves all existing assertions, and requires focused proof of exactly one versioned link PUT, one successful file-upload POST, enabled completion, synthetic conflict recovery, reload persistence, deterministic owned-server cleanup/diagnostics, screenshots, exact verification commands, and a clean final-tree fingerprint.

No production code, API/schema, infrastructure, AWS/provider access, compatibility shim, alternate route, or real data is in scope. Status: pending. Depends on: None. Blocks: None. Next owner: Software Engineer.

[alexeygrigorev]

CHANGES REQUESTED\n\nTester result for issue #216, exact candidate on branch issue-216-upload-sync at base/HEAD 7d77632.\n\nCandidate integrity:\n- Only tracked change: backend/e2e/canonical-task-workflow-behavior.spec.js\n- Candidate diff SHA-256 before and after testing: a7f4e0620359167542805e8543cfea3e813433615c40f6e28acd6d5d3fda13e5\n- No production, frontend runtime, backend runtime, infrastructure, or SAM source changes; no AWS/provider or real data used.\n- No hidden assertion deletion detected; the diff adds the required pending/upload/browser-diagnostic assertions and changes only issue-specific fixture/screenshot paths plus listener cleanup.\n\nChecks:\n- node --check backend/e2e/canonical-task-workflow-behavior.spec.js: PASS, exit 0\n- git diff --check: PASS, exit 0\n- node --test frontend/test/work-detail-surface.test.mjs: PASS, 35/35\n- npm run test:frontend:unit: PASS, 292/292, 25 suites\n- npm --prefix backend run typecheck: PASS, exit 0\n- npm --prefix backend test: PASS, 1094 passed, 0 failed, 1 skipped, 1095 tests / 166 suites\n- Focused real-server command with retries=0: PASS, 1/1 (initial 5.6s; confirmation rerun 3.4s)\n\nFull E2E, consecutive fresh local owned-server runs, CI= (configured retries disabled):\n1. CI= DATAOPS_E2E_SERVER_PORT=45163 npm --prefix backend run test:e2e: PASS, 92 passed, 6.7m; required #216 journey passed.\n2. CI= DATAOPS_E2E_SERVER_PORT=45163 npm --prefix backend run test:e2e: FAIL, 91 passed, 1 failed, 4.4m. The required #216 journey reached its workflow assertions but failed the final browser-diagnostic assertion with unexpected requestfailed entries: GET /work/api/cards/ and GET /work/api/notifications?limit=100, both net::ERR_ABORTED. The candidate allowlist permits cards/tasks/users reload aborts but not notifications, so the required journey did not pass initially on both full runs. The runner reported owned-server teardown stopped.\n\nEvidence:\n- .tmp/screenshots/issue-216/required-file-pending-disabled.png: native 1280x720; Saving Task link..., Version 1, disabled Choose File, no file attached.\n- .tmp/screenshots/issue-216/required-file-saved-uploaded.png: native 1280x720; refreshed-save success, Version 2, synthetic-proof.txt row.\n- The journey assertions covered exactly one versioned link PUT, zero file POST requests while pending, one successful POST /work/api/files (201) after enablement, row visibility, enabled completion, 409 conflict/recovery, durable completion, and reload persistence before the diagnostic failure.\n- Browser/page/console diagnostics otherwise had no pageerror or unexpected console error; expected conflict console output was filtered.\n- Dedicated source/SAM parity was not run because PM grooming scopes this candidate to the single E2E spec and no source/SAM/build artifact changed.\n\nRecommendation: keep #216 at CHANGES REQUESTED until the reload-abort diagnostic handling is corrected and the full E2E suite passes twice consecutively with the required journey passing initially both times.

[alexeygrigorev]

TESTER / REVIEW: CHANGES REQUESTED for candidate e54b77f1a8385b2914fc7d8ff092bb4ffef9fd949288fc33a5f0813f96a2f4f4. Runtime evidence was green (focused E2E 1/1; full E2E 92/92 twice; frontend 35/35 and 292/292; backend 1,094 passed/1 skipped; typecheck, syntax, diff check, and 1280x720 screenshots passed). Independent semantic review still requires a test-only repair before PM acceptance: delay the exact authoritative GET /work/api/tasks?cardId=<card.id> and assert pending/disabled/no-upload while it is outstanding; narrow net::ERR_ABORTED filtering to only GET /work/api/cards/<card.id> with no query and GET /work/api/notifications?limit=100, scoped to the deliberate reload window; strengthen task-scoped 201 upload metadata and authoritative one-file cardinality; and assert the synthetic 409 status/body/request payload. No commit or push is authorized yet.

[alexeygrigorev]

CHANGES REQUESTED

Independent Tester verification for issue #216 on branch issue-216-upload-sync, worktree /home/alexey/git/dataops-issue-216.

The focused #216 journey and all frontend/backend checks completed successfully, but the required two consecutive full capability-coverage suites could not be completed within the user-requested bounded run. The first full suite was interrupted at test 14/92; no second full suite was started. This cannot be accepted as a full-suite pass.

Checks and exact results:

• node --check backend/e2e/canonical-task-workflow-behavior.spec.js: PASS, exit 0.
• git diff --check: PASS, exit 0.
• CI= DATAOPS_CAPABILITY_COVERAGE=0 DATAOPS_E2E_SERVER_PORT=45162 npx playwright test backend/e2e/canonical-task-workflow-behavior.spec.js --grep "Required proof saves one versioned link, file, conflict, and durable completion" --retries=0 --reporter=line --output .tmp/test-results-issue-216/focused-run-1: PASS, 1/1, exit 0, 14.7s.
• node --test frontend/test/work-detail-surface.test.mjs: PASS, 35/35, exit 0.
• npm run test:frontend:unit: PASS, 292/292, 25 suites, exit 0.
• npm --prefix backend run typecheck: PASS, exit 0.
• npm --prefix backend test: PASS, 1,094 passed, 0 failed, 1 skipped, 1,095 tests across 166 suites, exit 0.
• CI= DATAOPS_CAPABILITY_COVERAGE=1 DATAOPS_E2E_SERVER_PORT=45163 npm --prefix backend run test:e2e -- --retries=0 --output /home/alexey/git/dataops-issue-216/.tmp/test-results-issue-216/full-run-1: INCOMPLETE, exit 130 after bounded interruption at 14/92; 13 passed, 1 interrupted, 78 did not run. The Stabilize required-file upload regression coverage after Task link save #216 journey had not yet run in this full suite.
• Required full-run 2: NOT RUN per bounded-finalization instruction; therefore two consecutive full passes are not established.

Focused acceptance evidence:

• Pending window: the delayed authoritative GET /work/api/tasks?cardId=<card.id> was outstanding after the versioned link PUT; Saving Task link… was visible, the required-file input was disabled, and upload request/response counts were both exactly zero.
• Authoritative save/upload: the link PUT returned 200 with the expected version and payload; the delayed task refresh returned 200; success feedback and enabled input were observed; exactly one POST /work/api/files returned 201; response and refreshed GET /work/api/files?taskId=<task.id>&limit=100 metadata matched the exact Task/Card, filename, category, and one-file cardinality; the file row appeared and completion became enabled.
• Synthetic conflict: the completion PUT returned exactly 409, the exact JSON body was {"error":"Synthetic route failure (409)"}, and the exact request payload contained expectedVersion and status: "done"; recovery and successful completion passed.
• Durable reload: after completion, reload reopened the same Task with done, the saved link, and synthetic-proof.txt; the focused browser-error assertion passed.
• Screenshots, both inspected at native dimensions: .tmp/screenshots/issue-216/required-file-pending-disabled.png (1280x720; pending message, disabled Choose File, no file attached) and .tmp/screenshots/issue-216/required-file-saved-uploaded.png (1280x720; refreshed-save success, file row). Neither shows a 404/error page, overlap, or missing state.
• Synthetic/local-only evidence: only the candidate E2E spec is modified; no production, infrastructure, AWS/provider, or source-repository changes were made. New generated results are under ignored .tmp/; .agent-runs/ was preserved untouched.

Additional CHANGES REQUESTED finding from exact-contract review:

• isExpectedReloadAbort currently allowlists nine reload URL shapes, including the Cards collection, multiple Task collection/detail reads, and Artifacts reads. The current PM review contract requires the deliberate reload-window filter to allow only GET /work/api/cards/<card.id> with no query and GET /work/api/notifications?limit=100. Narrow that allowlist before acceptance.

Final worktree evidence:

git status --short --branch --untracked-files=no
## issue-216-upload-sync
 M backend/e2e/canonical-task-workflow-behavior.spec.js

git diff --name-only
backend/e2e/canonical-task-workflow-behavior.spec.js

git diff --no-ext-diff --binary | sha256sum
6e66ebdc66d14ce28fe920ea9cdf48d8e79ed0091efe8005d08b4d13641ac684  -

The exact unstaged diff fingerprint was 6e66ebdc66d14ce28fe920ea9cdf48d8e79ed0091efe8005d08b4d13641ac684 before testing and is identical after testing. No stage, commit, push, or deploy was performed.

[alexeygrigorev]

TEST PASS

Fresh Tester verification for #216 candidate 063539797e913c1b92290532f3410e671dd2272ba8804bdfc921971c8cdd0cee on branch issue-216-upload-sync, worktree /home/alexey/git/dataops-issue-216.

Candidate integrity:

• Exact command git diff --no-ext-diff --binary | sha256sum: before testing 063539797e913c1b92290532f3410e671dd2272ba8804bdfc921971c8cdd0cee; after all testing 063539797e913c1b92290532f3410e671dd2272ba8804bdfc921971c8cdd0cee.
• Base HEAD remained 7d776325c7c869a5ee47c498015e4b9b7314d90c.
• Only tracked change is backend/e2e/canonical-task-workflow-behavior.spec.js; no staged paths, production/runtime/infrastructure/provider changes, commit, push, or deploy.
• The pre-existing .agent-runs/ evidence was preserved unchanged (30 files). Fresh logs/results were kept under .tmp/.

Checks (all exit 0):

• node --check backend/e2e/canonical-task-workflow-behavior.spec.js: PASS.
• git diff --check: PASS.
• CI= DATAOPS_CAPABILITY_COVERAGE=0 DATAOPS_E2E_SERVER_PORT=45162 npx playwright test backend/e2e/canonical-task-workflow-behavior.spec.js --grep "Required proof saves one versioned link, file, conflict, and durable completion" --retries=0 --reporter=line --output .tmp/test-results-issue-216/focused-run-1: PASS, 1/1, 8.0s.
• node --test frontend/test/work-detail-surface.test.mjs: PASS, 35/35.
• npm run test:frontend:unit: PASS, 292/292 across 25 suites.
• npm --prefix backend run typecheck: PASS.
• npm --prefix backend test: PASS, 1,094 passed, 0 failed, 1 skipped, 1,095 tests across 166 suites.
• CI= DATAOPS_CAPABILITY_COVERAGE=1 DATAOPS_E2E_SERVER_PORT=45162 npm --prefix backend run test:e2e -- --retries=0 --output .tmp/test-results-issue-216/full-run-1: PASS, 92/92, 5.7m, exit 0; capability evidence ok=true, 142 stable states.
• CI= DATAOPS_CAPABILITY_COVERAGE=1 DATAOPS_E2E_SERVER_PORT=45162 npm --prefix backend run test:e2e -- --retries=0 --output .tmp/test-results-issue-216/full-run-2: PASS, 92/92, 7.0m, exit 0; capability evidence ok=true, 142 stable states.

Acceptance evidence:

• The focused and full Stabilize required-file upload regression coverage after Task link save #216 journey passed. A synthetic 500ms delay held the authoritative GET /work/api/tasks?cardId=<card.id> refresh outstanding after the versioned link PUT; Saving Task link… was visible, the required-file input was disabled, and upload request/response counts were exactly zero.
• After the authoritative refresh, the input was enabled. Exactly one POST /work/api/files returned 201; response metadata and the authoritative GET /work/api/files?taskId=<task.id>&limit=100 list matched the exact Task/Card, filename synthetic-proof.txt, category document, and one-item/no-cursor cardinality.
• The synthetic conflict returned exactly 409 with body {"error":"Synthetic route failure (409)"}; the request payload was exactly {"expectedVersion":<saved version>,"status":"done"}. Recovery, durable completion, and reload persistence of the done state, link, and file passed.
• The reload diagnostic has the exact two-url net::ERR_ABORTED allowlist: GET /work/api/cards/<encoded card.id> and GET /work/api/notifications?limit=100. The deliberate reload is preceded by page.waitForLoadState('networkidle'); no unexpected browser/page/console errors were reported.
• Screenshots were captured and visually inspected at native 1280x720: .tmp/screenshots/issue-216/required-file-pending-disabled.png shows the pending save, disabled Choose File, and no attached file; .tmp/screenshots/issue-216/required-file-saved-uploaded.png shows refreshed success and synthetic-proof.txt. Neither shows a 404/error page, overlap, broken layout, or missing state.
• Logs and per-run capability evidence are under .tmp/test-results-issue-216/. The owned server was torn down after each full run and port 45162 was free afterward.

No commit or push was performed.

[alexeygrigorev]

PM ACCEPTED

Candidate fingerprint: 063539797e913c1b92290532f3410e671dd2272ba8804bdfc921971c8cdd0cee
Candidate worktree: /home/alexey/git/dataops-issue-216
Base HEAD: 7d77632

The PM review confirms the acceptance contract:

• The only tracked unstaged change is backend/e2e/canonical-task-workflow-behavior.spec.js. There are no staged paths and no production, runtime, infrastructure, AWS/provider, API, schema, compatibility, or alternate-route changes.
• The pending state is proven with the authoritative card-scoped Task refresh held open: Saving Task link... is visible, the required-file input is disabled, and upload request/response counts are zero.
• After authoritative refresh, the input is enabled; exactly one task/card-scoped POST /work/api/files returns 201, the refreshed file list has exactly one matching document with no cursor, the file row is visible, and completion is enabled.
• Versioning, synthetic 409 status/body/request assertions, recovery, durable completion, reload persistence, and browser diagnostics pass. Reload abort filtering is limited to the two exact expected GET URLs and the deliberate reload window.
• Screenshots were captured and inspected at native 1280x720: .tmp/screenshots/issue-216/required-file-pending-disabled.png and .tmp/screenshots/issue-216/required-file-saved-uploaded.png. They show the required pending-disabled and saved-uploaded states with no error page, overlap, or missing state.
• Required verification is satisfied: focused E2E 1/1; frontend checks 35/35 and 292/292; backend typecheck; backend tests 1,094 passed, 0 failed, 1 skipped; and two complete fresh full E2E runs, each 92/92 with exit 0 and capability evidence ok=true for 142 stable states. Syntax and diff checks also pass.

This is PM acceptance of the tested candidate only. The next lifecycle gate is the Software Engineer commit with the final clean tracked-tree fingerprint recorded; no commit, merge, push, or issue close is authorized by this acceptance comment.

[alexeygrigorev]

PM TRACKER RECONCILIATION — Tester/PM acceptance and exact commit 7564688 in local main ancestry are now reflected. The commit remains unpushed and unshipped. Coordinated publication waits for #217 release/identity PASS and then On-Call; no implementation or test rerun is requested.