From 5773b209ed8730ab8e5d36b5fe666ddd4b977218 Mon Sep 17 00:00:00 2001 From: Stanislas Date: Fri, 12 Jun 2026 17:16:24 +0200 Subject: [PATCH 1/3] Add quote around expected site and dd_url value to match new example --- unit_tests/test_install_script.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unit_tests/test_install_script.sh b/unit_tests/test_install_script.sh index 5b739a88..637bbdf2 100755 --- a/unit_tests/test_install_script.sh +++ b/unit_tests/test_install_script.sh @@ -88,7 +88,7 @@ testUpdateSite() { testNoSite() { sudo cp ${config_file}.example $config_file update_site "sudo" "" $config_file - sudo grep -wq "^# site: datadoghq.com$" $config_file + sudo grep -wq "^# site: "datadoghq.com"$" $config_file assertEquals 0 $? } @@ -106,7 +106,7 @@ testUrlUpdated() { testNoUrl() { sudo cp ${config_file}.example $config_file update_url "sudo" "" $config_file - sudo grep -wq "^# dd_url: https:\/\/app.datadoghq.com$" $config_file + sudo grep -wq "^# dd_url: "https:\/\/app.datadoghq.com"$" $config_file assertEquals 0 $? } From 062677e01e75261afa86aaeec7fbc401f0325100 Mon Sep 17 00:00:00 2001 From: Stanislas167 Date: Fri, 12 Jun 2026 17:28:37 +0200 Subject: [PATCH 2/3] Update test_install_script.sh --- unit_tests/test_install_script.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unit_tests/test_install_script.sh b/unit_tests/test_install_script.sh index 637bbdf2..5b89c1fa 100755 --- a/unit_tests/test_install_script.sh +++ b/unit_tests/test_install_script.sh @@ -88,7 +88,7 @@ testUpdateSite() { testNoSite() { sudo cp ${config_file}.example $config_file update_site "sudo" "" $config_file - sudo grep -wq "^# site: "datadoghq.com"$" $config_file + sudo grep -wq "^# site: \"datadoghq.com\"$" $config_file assertEquals 0 $? } @@ -106,7 +106,7 @@ testUrlUpdated() { testNoUrl() { sudo cp ${config_file}.example $config_file update_url "sudo" "" $config_file - sudo grep -wq "^# dd_url: "https:\/\/app.datadoghq.com"$" $config_file + sudo grep -wq "^# dd_url: \"https:\/\/app.datadoghq.com\"$" $config_file assertEquals 0 $? } From 580cba6171df8438d2db944b6995713cfb9eee18 Mon Sep 17 00:00:00 2001 From: Stanislas Date: Thu, 18 Jun 2026 15:17:36 +0200 Subject: [PATCH 3/3] expected the value, quoted or not --- unit_tests/test_install_script.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unit_tests/test_install_script.sh b/unit_tests/test_install_script.sh index 5b89c1fa..b932299c 100755 --- a/unit_tests/test_install_script.sh +++ b/unit_tests/test_install_script.sh @@ -88,7 +88,7 @@ testUpdateSite() { testNoSite() { sudo cp ${config_file}.example $config_file update_site "sudo" "" $config_file - sudo grep -wq "^# site: \"datadoghq.com\"$" $config_file + sudo grep -wq "^# site: datadoghq.com$" $config_file || sudo grep -wq "^# site: \"datadoghq.com\"$" $config_file assertEquals 0 $? } @@ -106,7 +106,7 @@ testUrlUpdated() { testNoUrl() { sudo cp ${config_file}.example $config_file update_url "sudo" "" $config_file - sudo grep -wq "^# dd_url: \"https:\/\/app.datadoghq.com\"$" $config_file + sudo grep -wq "^# dd_url: https:\/\/app.datadoghq.com$" $config_file || sudo grep -wq "^# dd_url: \"https:\/\/app.datadoghq.com\"$" $config_file assertEquals 0 $? }