diff --git a/.github/ISSUE_TEMPLATE/milestone-close-out.yml b/.github/ISSUE_TEMPLATE/milestone-close-out.yml index 0d66b12..4760d91 100644 --- a/.github/ISSUE_TEMPLATE/milestone-close-out.yml +++ b/.github/ISSUE_TEMPLATE/milestone-close-out.yml @@ -35,10 +35,11 @@ body: label: Checklist options: - label: Verify that every exit criterion is met, or record an explicit waiver. + - label: Check each consequence listed in this milestone's Groom issue. Every one must be done, or handed to a named owner in an issue, before this chore can close. - label: "List the versions the release train shipped during this milestone. If user-visible work landed and no version was cut, raise it in #kharon (or in #needs-lothrop if it needs Lothrop's call), and don't cut one here." + - label: Create the next milestone with a title only (its Groom sets the goal, exit criteria, and due date). Then open its three chore issues (Groom, Scope check, and Close-out) from the issue forms and put them in it. - label: Move every unfinished issue on purpose, either into the next milestone or back to `next`. - label: Write a short retro covering what to keep, drop, or change for the next milestone. - - label: Create the next milestone with a title only (its Groom sets the goal, exit criteria, and due date). Then open its three chore issues (Groom, Scope check, and Close-out) from the issue forms and put them in it. - label: Assign those chores with `assigned:` labels following the rotation (nyx → muse → duet → nyx). Each chore goes to a different agent, and no chore type repeats this milestone's agent. - label: Close this issue and then the milestone. - type: textarea @@ -48,6 +49,13 @@ body: description: Tags or release URLs the train cut during this milestone. Write "none" if it cut none. validations: required: true + - type: textarea + id: consequences + attributes: + label: Consequences + description: Each consequence from the Groom issue and its state, either done (with a link) or handed off (with the owner and the issue). Write "none" if the Groom listed none. + validations: + required: true - type: textarea id: retro attributes: diff --git a/.github/ISSUE_TEMPLATE/milestone-groom.yml b/.github/ISSUE_TEMPLATE/milestone-groom.yml index fcdd858..c74942d 100644 --- a/.github/ISSUE_TEMPLATE/milestone-groom.yml +++ b/.github/ISSUE_TEMPLATE/milestone-groom.yml @@ -36,6 +36,7 @@ body: - label: Fill in the milestone (the prior Close-out created it with a title only). Put its goal and exit criteria in the description and set a due date. - label: Pull issues from `next` (and from the prior milestone's leftovers) into this milestone, or write new ones, covering this scope and only this scope. - label: Size each issue, apply type and priority labels, and put the issues in delivery order. + - label: "For each gate in the exit criteria, list its consequences: the state changes that finishing it triggers elsewhere, written as conditional tasks (for example \"on canary pass: flip #346/#347 to supported\")." - label: Make sure this milestone's Scope check and Close-out issues exist and are in it. - label: Confirm the `assigned:` label matches the dropdown. Don't use the label as a substitute for GitHub assignees. - type: textarea @@ -45,6 +46,13 @@ body: description: The milestone's goal and the conditions under which it is done. Copy them into the milestone description. validations: required: true + - type: textarea + id: consequences + attributes: + label: Consequences + description: For each gate, the downstream state changes its completion triggers, one conditional task per line, for example "on canary pass, flip #346/#347 to supported". Write "none" if no gate triggers anything. Close-out isn't done until each one is done or handed to a named owner. + validations: + required: true - type: textarea id: notes attributes: diff --git a/docs/milestone-chores.md b/docs/milestone-chores.md index c919427..76762f2 100644 --- a/docs/milestone-chores.md +++ b/docs/milestone-chores.md @@ -14,9 +14,9 @@ Platform goals are still tracked with `platform:` labels and tracking issues. ## The three chores -1. **Groom** (start). Set the milestone's goal, exit criteria, and due date (the prior Close-out created it with a title only). Then write, size, label, and order its issues, pulling them from `next`. +1. **Groom** (start). Set the milestone's goal, exit criteria, and due date (the prior Close-out created it with a title only). Then write, size, label, and order its issues, pulling them from `next`. For each gate in the exit criteria, list its consequences: the state changes elsewhere that finishing the gate triggers (for example, flipping a platform to supported once its canary passes). 2. **Scope check** (around the midpoint, using the due date). Compare the open work to the exit criteria, and cut or defer anything that has drifted. Ping Lothrop in #needs-lothrop only when a decision is needed. -3. **Close-out** (end). Verify the exit criteria or record a waiver, and list the versions the train shipped during the milestone. Move unfinished issues on purpose, write a short retro, create the next milestone (title only) and open its three chores in it, and then close this issue and the milestone. Close-out doesn't cut a release; the train does that whenever its gate passes. +3. **Close-out** (end). Verify the exit criteria or record a waiver, confirm that every consequence from the Groom is done or handed to a named owner, and list the versions the train shipped during the milestone. Create the next milestone (title only) and open its three chores in it, move unfinished issues on purpose (into that milestone or back to `next`), write a short retro, and then close this issue and the milestone. Close-out doesn't cut a release; the train does that whenever its gate passes. Use the issue forms in `.github/ISSUE_TEMPLATE/`. Open all three chores into the milestone they belong to, then apply exactly one of `assigned:nyx`, `assigned:muse`, or `assigned:duet`.