From 2e3695e80a9ed64e10a9446842e9a23b1342bf17 Mon Sep 17 00:00:00 2001 From: Frederik van der Els <49305700+xpple@users.noreply.github.com> Date: Thu, 10 Apr 2025 20:04:37 +0200 Subject: [PATCH 1/3] Fix biomes for igloos and mansions --- finders.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/finders.c b/finders.c index 783d5ecc..61d2d7d9 100644 --- a/finders.c +++ b/finders.c @@ -1195,7 +1195,7 @@ int isViableFeatureBiome(int mc, int structureType, int biomeID) case Igloo: if (mc <= MC_1_8) return 0; - return biomeID == snowy_tundra || biomeID == snowy_taiga || biomeID == snowy_slopes; + return biomeID == snowy_taiga || biomeID == snowy_plains || biomeID == snowy_slopes; case Ocean_Ruin: if (mc <= MC_1_12) return 0; @@ -1282,7 +1282,7 @@ int isViableFeatureBiome(int mc, int structureType, int biomeID) case Mansion: if (mc <= MC_1_10) return 0; - return biomeID == dark_forest || biomeID == dark_forest_hills; + return biomeID == dark_forest || biomeID == dark_forest_hills || biomeID == pale_garden; case Fortress: return (biomeID == nether_wastes || biomeID == soul_sand_valley || From 3aaf7d196ba81f7f1af8c43491a4995f17813d7f Mon Sep 17 00:00:00 2001 From: Frederik van der Els <49305700+xpple@users.noreply.github.com> Date: Thu, 10 Apr 2025 20:15:34 +0200 Subject: [PATCH 2/3] Add back Snowy Tundra (old biome) --- finders.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/finders.c b/finders.c index 61d2d7d9..c8134767 100644 --- a/finders.c +++ b/finders.c @@ -1195,7 +1195,8 @@ int isViableFeatureBiome(int mc, int structureType, int biomeID) case Igloo: if (mc <= MC_1_8) return 0; - return biomeID == snowy_taiga || biomeID == snowy_plains || biomeID == snowy_slopes; + return (biomeID == snowy_tundra || biomeID == snowy_taiga + || biomeID == snowy_plains || biomeID == snowy_slopes); case Ocean_Ruin: if (mc <= MC_1_12) return 0; From eeae66c92ef6938ebfc960883ed006d4ecb2c4f1 Mon Sep 17 00:00:00 2001 From: Frederik van der Els Date: Thu, 9 Oct 2025 20:25:17 +0200 Subject: [PATCH 3/3] Add version check for mansions --- biomes.h | 3 ++- finders.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/biomes.h b/biomes.h index eaf85ff5..52d10fd0 100644 --- a/biomes.h +++ b/biomes.h @@ -35,7 +35,8 @@ enum MCVersion MC_1_21_1, MC_1_21_3, MC_1_21_WD, // Winter Drop, version TBA - MC_1_21 = MC_1_21_WD, + MC_1_21_5, + MC_1_21 = MC_1_21_5, MC_NEWEST = MC_1_21, }; diff --git a/finders.c b/finders.c index c8134767..0aae06c5 100644 --- a/finders.c +++ b/finders.c @@ -1283,7 +1283,7 @@ int isViableFeatureBiome(int mc, int structureType, int biomeID) case Mansion: if (mc <= MC_1_10) return 0; - return biomeID == dark_forest || biomeID == dark_forest_hills || biomeID == pale_garden; + return biomeID == dark_forest || biomeID == dark_forest_hills || (mc >= MC_1_21_5 && biomeID == pale_garden); case Fortress: return (biomeID == nether_wastes || biomeID == soul_sand_valley ||