test: address CodeRabbit feedback on git cache edge cases

Cover empty existing cache dirs separately from missing paths, narrow
corrupt-JSON exceptions to JSONDecodeError/CpaError, and assert fresh
metadata does not refresh under stale mode.

Author: AshSgDe29071999

packages/create-python-app-core/tests/test_git_cache.py

@@ -140,6 +140,9 @@ def test_missing_subdir_forces_refresh_when_meta_is_fresh(tmp_path: Path) -> Non
 def test_read_cache_meta_empty_dir(tmp_path: Path) -> None:
     from create_python_app_core.git_cache import read_cache_meta
 
+    empty = tmp_path / "empty-entry"
+    empty.mkdir()
+    assert read_cache_meta(empty) is None
     assert read_cache_meta(tmp_path / "missing") is None
 
 
@@ -150,8 +153,7 @@ def test_read_cache_meta_corrupt_json(tmp_path: Path) -> None:
     entry = tmp_path / "e"
     entry.mkdir()
     meta_path(entry).write_text("{not-json", encoding="utf-8")
-    with pytest.raises((json.JSONDecodeError, CpaError, TypeError, ValueError)):
-        # Current implementation lets JSONDecodeError propagate; either is acceptable.
+    with pytest.raises((json.JSONDecodeError, CpaError)):
         read_cache_meta(entry)
 
 
@@ -168,6 +170,7 @@ def test_should_refresh_modes() -> None:
     meta = CacheMeta(url="u", ref="main", fetched_at=time.time(), commit="abc")
     assert _should_refresh(None, "stale") is True
     assert _should_refresh(meta, "manual") is False
+    assert _should_refresh(meta, "stale") is False
     assert _should_refresh(meta, "always") is True
     old = CacheMeta(url="u", ref="main", fetched_at=time.time() - 100_000, commit="abc")
     assert _should_refresh(old, "stale") is True