Skip to content

Fix typo and idiomatic empty check in converter_lib.cpp #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nunoplopes merged 3 commits into from
May 18, 2026
Merged

Fix typo and idiomatic empty check in converter_lib.cpp #116

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd4dc78
Initial plan
Copilot May 17, 2026
406c47e
Fix typo, idiomatic empty check, and missing nullptr arg in converter…
Copilot May 17, 2026
7836d00
Revert GetTemplateArgs nullptr change per review feedback
Copilot May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp2rust/converter/converter_lib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ GetUserDefinedDefaultConstructor(const clang::CXXRecordDecl *decl) {

std::string GetMainFileName(const clang::ASTContext &ctx) {
const auto &src_mgr = ctx.getSourceManager();
auto filed_id = src_mgr.getMainFileID();
auto file_entry = src_mgr.getFileEntryRefForID(filed_id);
auto file_id = src_mgr.getMainFileID();
auto file_entry = src_mgr.getFileEntryRefForID(file_id);
auto file_path = file_entry->getName();
auto file_name = llvm::sys::path::filename(file_path);
return llvm::sys::path::stem(file_name).str();
Expand Down Expand Up @@ -399,7 +399,7 @@ std::string GetNamedDeclAsString(const clang::NamedDecl *decl) {
}
}

if (name.size() == 0) {
if (name.empty()) {
name = "self";
}

Expand Down
Loading