Handle string literalt to char* conversion

Author: lucic71

cpp2rust/converter/converter.cpp

@@ -1752,6 +1752,9 @@ bool Converter::VisitImplicitCastExpr(clang::ImplicitCastExpr *expr) {
   }
   case clang::CastKind::CK_NoOp: {
     Convert(sub_expr);
+    if (IsConversionFromStringLiteralToCharPtr(expr)) {
+      StrCat(".cast_mut()");
+    }
     break;
   }
   case clang::CastKind::CK_FunctionToPointerDecay:

cpp2rust/converter/converter_lib.cpp

@@ -763,4 +763,10 @@ void Unwrap(std::string &s, std::string_view prefix, std::string_view suffix) {
   }
 }
 
+bool IsConversionFromStringLiteralToCharPtr(clang::Expr *expr) {
+  return clang::isa<clang::StringLiteral>(expr->IgnoreImplicit()) &&
+         expr->getType()->isPointerType() &&
+         expr->getType()->getPointeeType()->isCharType();
+}
+
 } // namespace cpp2rust

cpp2rust/converter/converter_lib.h

@@ -167,4 +167,6 @@ std::vector<clang::Stmt *> GetSwitchCaseBody(clang::CompoundStmt *body,
 
 void Unwrap(std::string &s, std::string_view prefix, std::string_view suffix);
 
+bool IsConversionFromStringLiteralToCharPtr(clang::Expr *expr);
+
 } // namespace cpp2rust

cpp2rust/converter/models/converter_refcount.cpp

@@ -1033,6 +1033,11 @@ bool ConverterRefCount::VisitImplicitCastExpr(clang::ImplicitCastExpr *expr) {
     return false;
   }
 
+  if (expr->getCastKind() == clang::CastKind::CK_NoOp) {
+    Convert(sub_expr);
+    return false;
+  }
+
   return Converter::VisitImplicitCastExpr(expr);
 }