Define static array of char[] generics

Author: lucic71

cpp2rust/converter/mapper.cpp

@@ -226,7 +226,6 @@ matchTemplate(const std::string &template_str,
   size_t si = 0;
 
   while (ti < template_str.size()) {
-    // Match T{N}. TODO: currently only T0..9 are supported
     if (template_str[ti] == 'T' && ti + 1 < template_str.size() &&
         std::isdigit(template_str[ti + 1])) {
       size_t tj = ti + 2;
@@ -235,6 +234,8 @@ matchTemplate(const std::string &template_str,
       }
 
       size_t type_idx = std::stoi(&template_str[ti + 1]) - 1;
+      assert(type_idx < TranslationRule::kMaxGenerics &&
+             "template placeholder exceeds kMaxGenerics");
       ti = tj;
 
       std::string_view nextLit;

cpp2rust/converter/translation_rule.cpp

@@ -7,7 +7,6 @@
 #include <llvm/Support/MemoryBuffer.h>
 
 #include <algorithm>
-#include <format>
 #include <string>
 #include <vector>
 
@@ -17,6 +16,21 @@ namespace cpp2rust::TranslationRule {
 
 namespace {
 
+struct GenericPlaceholders {
+  char storage[kMaxGenerics][3]{};
+
+  constexpr GenericPlaceholders() {
+    for (unsigned i = 0; i < kMaxGenerics; ++i) {
+      storage[i][0] = 'T';
+      storage[i][1] = static_cast<char>('1' + i);
+      storage[i][2] = '\0';
+    }
+  }
+};
+static_assert(kMaxGenerics <= 9,
+              "GenericPlaceholders assumes single-digit names");
+constexpr GenericPlaceholders kGenericPlaceholders{};
+
 TypeInfo ParseTypeInfoJSON(const llvm::json::Object &obj) {
   TypeInfo info;
   if (auto ty = obj.getString("type"))
@@ -307,9 +321,10 @@ void ExprRule::validate(const std::string &name) const {
     assert(0 && "Expr rule loaded from IR but has no src");
   }
 
-  // Check that both source and target use the same generics.
-  for (unsigned i = 0; i < generics.size(); ++i) {
-    auto placeholder = std::format("T{}", i + 1);
+  assert(generics.size() <= kMaxGenerics &&
+         "rule declares more generics than kMaxGenerics");
+  for (unsigned i = 0, e = generics.size(); i < e; ++i) {
+    const char *placeholder = kGenericPlaceholders.storage[i];
     if (src.find(placeholder) == std::string::npos) {
       llvm::errs() << name << '\n';
       dump();

cpp2rust/converter/translation_rule.h

@@ -15,6 +15,8 @@
 
 namespace cpp2rust::TranslationRule {
 
+inline constexpr unsigned kMaxGenerics = 9;
+
 struct TextFragment {
   std::string text;