Description
When the analyzer runs on itself, two usability/quality issues remain:
--warnings-only still prints all functions, even those without warnings/errors, which creates noise and slows down triage.- A false positive
DuplicateIfCondition is reported in stripIntCasts(...) (InvalidBaseReconstruction.cpp) due to a redundant conditional return pattern.
Expected behavior:
- In
--warnings-only, human output should list only functions that have at least one non-info diagnostic.
- No
unreachable else-if branch warning should be emitted for stripIntCasts(...).
Acceptance criteria:
--warnings-only output is function-filtered by remaining diagnostics.- Self-analysis of
src/analysis/InvalidBaseReconstruction.cpp no longer emits that warning.
- Regression tests cover the
--warnings-only function-listing behavior.
Description
When the analyzer runs on itself, two usability/quality issues remain:
--warnings-onlystill prints all functions, even those without warnings/errors, which creates noise and slows down triage.DuplicateIfConditionis reported instripIntCasts(...)(InvalidBaseReconstruction.cpp) due to a redundant conditional return pattern.Expected behavior:
--warnings-only, human output should list only functions that have at least one non-info diagnostic.unreachable else-if branchwarning should be emitted forstripIntCasts(...).Acceptance criteria:
--warnings-onlyoutput is function-filtered by remaining diagnostics.src/analysis/InvalidBaseReconstruction.cppno longer emits that warning.--warnings-onlyfunction-listing behavior.