From 42cb7c34303322096457ef0273eb1dd09759f60b Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Thu, 2 Jul 2026 18:04:25 +0900 Subject: [PATCH 1/4] test: cover export fallback behavior --- apps/desktop/src/lib/export.test.ts | 30 +++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/apps/desktop/src/lib/export.test.ts b/apps/desktop/src/lib/export.test.ts index 265e983d..88135f1e 100644 --- a/apps/desktop/src/lib/export.test.ts +++ b/apps/desktop/src/lib/export.test.ts @@ -143,6 +143,34 @@ describe("export generation", () => { expect(parsed.headline).toBe(""); }); + it("generates chart summary JSON when export summary is absent", () => { + const songWithoutExportSummary: RehearsalSong = { + ...mockSong, + exportSummary: undefined + }; + + const parsed = JSON.parse(generateChartSummaryJson(songWithoutExportSummary)); + + expect(parsed).toMatchObject({ + title: "Test", + headline: "", + sections: [ + { + label: "verse", + groove: "swing", + roles: [ + { + name: "Bass", + chord: "=Cmaj7", + cue: "1, 2, 3", + priority: "high" + } + ] + } + ] + }); + }); + it("generates a metadata-only local handoff without source paths or transcription data", () => { const sourceBootstrap: ProjectBootstrapSummary = { projectId: "project-1", @@ -213,6 +241,8 @@ describe("export generation", () => { title: "Test", workspaceVersion: 1 }); + expect(parsed.sourceAssets).toEqual([]); + expect(json).not.toContain("sourcePath"); }); it("creates a local re-analysis request from a received handoff and selected replacement asset", () => { From 9e4bd2655ca3d1a4559363f50c54272ca937aadf Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Thu, 2 Jul 2026 19:41:25 +0900 Subject: [PATCH 2/4] test: harden export fallback assertions --- apps/desktop/src/lib/export.test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/desktop/src/lib/export.test.ts b/apps/desktop/src/lib/export.test.ts index 88135f1e..6b451381 100644 --- a/apps/desktop/src/lib/export.test.ts +++ b/apps/desktop/src/lib/export.test.ts @@ -144,13 +144,12 @@ describe("export generation", () => { }); it("generates chart summary JSON when export summary is absent", () => { - const songWithoutExportSummary: RehearsalSong = { - ...mockSong, - exportSummary: undefined - }; + const songWithoutExportSummary: Partial = { ...mockSong }; + delete songWithoutExportSummary.exportSummary; - const parsed = JSON.parse(generateChartSummaryJson(songWithoutExportSummary)); + const parsed = JSON.parse(generateChartSummaryJson(songWithoutExportSummary as RehearsalSong)); + expect("exportSummary" in songWithoutExportSummary).toBe(false); expect(parsed).toMatchObject({ title: "Test", headline: "", @@ -230,7 +229,7 @@ describe("export generation", () => { }); }); - it("uses the song identity as the default handoff workspace identity", () => { + it("uses the song identity and an empty source asset list as the default handoff identity", () => { const json = generateMetadataHandoffJson(mockSong, { createdAt: "2026-06-15T08:30:00.000Z" }); @@ -241,6 +240,7 @@ describe("export generation", () => { title: "Test", workspaceVersion: 1 }); + expect(parsed).toHaveProperty("sourceAssets"); expect(parsed.sourceAssets).toEqual([]); expect(json).not.toContain("sourcePath"); }); From e48ec7f442f9cf22e3a991bcc4c7c5d51f6ef82b Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Thu, 2 Jul 2026 15:20:17 +0900 Subject: [PATCH 3/4] fix: update anyhow for RustSec 2026-0190 --- apps/desktop/src-tauri/Cargo.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/desktop/src-tauri/Cargo.lock b/apps/desktop/src-tauri/Cargo.lock index 4d9ae737..0df254ea 100644 --- a/apps/desktop/src-tauri/Cargo.lock +++ b/apps/desktop/src-tauri/Cargo.lock @@ -28,9 +28,9 @@ dependencies = [ [[package]] name = "anyhow" -version = "1.0.102" +version = "1.0.103" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "7f202df86484c868dbad7eaa557ef785d5c66295e41b460ef922eca0723b842c" +checksum = "2a4385e2e34eb35d6b3efe798b9eb88096925d87726c0798709bf56d9ed84af3" [[package]] name = "atk" From a738d648b8c6b82c8e710a2684be9ca38a19c860 Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Thu, 2 Jul 2026 19:45:56 +0900 Subject: [PATCH 4/4] fix: document quick-xml advisory exceptions --- apps/desktop/src-tauri/.cargo/audit.toml | 2 ++ apps/desktop/src-tauri/osv-scanner.toml | 8 ++++++++ docs/security/dependency-policy.md | 1 + 3 files changed, 11 insertions(+) diff --git a/apps/desktop/src-tauri/.cargo/audit.toml b/apps/desktop/src-tauri/.cargo/audit.toml index 9fc2a4f3..861e0aa5 100644 --- a/apps/desktop/src-tauri/.cargo/audit.toml +++ b/apps/desktop/src-tauri/.cargo/audit.toml @@ -17,4 +17,6 @@ ignore = [ "RUSTSEC-2025-0100", # unic-ucd-ident: unmaintained "RUSTSEC-2025-0098", # unic-ucd-version: unmaintained "RUSTSEC-2024-0429", # glib 0.18.5: VariantStrIter unsoundness, transitive via Tauri/wry/webkit2gtk/gtk GTK3 stack; remove when upstream drops or patches the chain + "RUSTSEC-2026-0194", # quick-xml 0.39.4: inherited via Tauri/plist and rfd/wayland-scanner; no compatible upstream release has moved both chains to quick-xml >=0.41.0 yet + "RUSTSEC-2026-0195", # quick-xml 0.39.4: same owner chain and removal condition as RUSTSEC-2026-0194 ] diff --git a/apps/desktop/src-tauri/osv-scanner.toml b/apps/desktop/src-tauri/osv-scanner.toml index 16b3b20e..c8fc5e44 100644 --- a/apps/desktop/src-tauri/osv-scanner.toml +++ b/apps/desktop/src-tauri/osv-scanner.toml @@ -65,3 +65,11 @@ reason = "Inherited through the current Tauri GTK3 owner chain and already track [[IgnoredVulns]] id = "RUSTSEC-2024-0429" reason = "glib 0.18.5 VariantStrIter advisory inherited through Tauri/wry/webkit2gtk/gtk; allowed only until upstream drops or patches the chain, with scope guarded by scripts/checks/verify_supply_chain.py." + +[[IgnoredVulns]] +id = "RUSTSEC-2026-0194" +reason = "quick-xml 0.39.4 duplicate-attribute advisory is inherited through Tauri/plist and rfd/wayland-scanner; current compatible upstream crates do not yet allow quick-xml >=0.41.0, and this app does not expose those XML parser paths to untrusted user XML." + +[[IgnoredVulns]] +id = "RUSTSEC-2026-0195" +reason = "quick-xml 0.39.4 namespace-allocation advisory is inherited through the same Tauri/plist and rfd/wayland-scanner owner chain as RUSTSEC-2026-0194; remove once compatible upstream crates move to quick-xml >=0.41.0." diff --git a/docs/security/dependency-policy.md b/docs/security/dependency-policy.md index d3a9680e..d7c7acad 100644 --- a/docs/security/dependency-policy.md +++ b/docs/security/dependency-policy.md @@ -104,6 +104,7 @@ Current controlled exceptions: - No Python vulnerability exceptions are active. `GHSA-5239-wwwm-4pmq` (`Pygments <2.20.0`) was removed by locking `Pygments` to `2.20.0`; the CI `security-audit` workflow must run `pip-audit --local --strict` against the synced `uv` environment without a targeted ignore for that advisory. - Cargo audit warnings for legacy `gtk3` vulnerabilities (e.g. `RUSTSEC-2024-0413`) inherited through Tauri v2 `wry`/`webkit2gtk` integration are explicitly allowed. These are deep framework dependencies with no alternative, so they are documented exceptions and ignored by default. - `RUSTSEC-2024-0429` for `glib 0.18.5` is allowed only for the `VariantStrIter` advisory inherited through the Tauri/wry/webkit2gtk/gtk GTK3 stack. A compatible lockfile refresh can move the desktop stack to `tauri 2.11.3`, `wry 0.55.1`, `tao 0.35.3`, `muda 0.19.3`, and related transitive patches, but it still does not move this stack to patched `glib >=0.20.0`; the exception must remain encoded in repo-controlled audit configuration and guarded by `scripts/checks/verify_supply_chain.py`, and it must be removed when upstream drops or patches the chain. +- `RUSTSEC-2026-0194` and `RUSTSEC-2026-0195` for `quick-xml 0.39.4` are allowed only while the current compatible upstream owner chains still require vulnerable `quick-xml`: `plist 1.9.0` through Tauri, and `wayland-scanner 0.31.10` through Linux `rfd`/Wayland dependencies. `quick-xml >=0.41.0` is patched, but `plist 1.9.0` requires `quick-xml ^0.39.2` and the current `wayland-scanner` release also has no compatible patched path. BandScope does not expose either owner chain as a user-controlled XML ingestion surface; the exception must stay encoded in repo-controlled cargo-audit and OSV configuration, and must be removed once compatible upstream crates publish a patched dependency path. Retired third-party deprecation and advisory signal: