You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Colour detection lambda is being called multiple times in multiplemethods so should probably become a private method in the detector class
In detectIfCardUp (line 94) we are checking to see the result of a bool expression and returning true if true and false if false. Could change this to just return the bool expression, i.e return whitePrecentage > notWhitePercentage
Might be an idea to remove some of the less helpful windows like canny and greyscale? Not sure if we need these. Or we could add these as option through command line arguments? Not really sure
Colour detection lambda is being called multiple times in multiplemethods so should probably become a private method in the detector class
In detectIfCardUp (line 94) we are checking to see the result of a bool expression and returning true if true and false if false. Could change this to just return the bool expression, i.e
return whitePrecentage > notWhitePercentageMight be an idea to remove some of the less helpful windows like canny and greyscale? Not sure if we need these. Or we could add these as option through command line arguments? Not really sure