From ee5b4b9e239ece22a8d2173ab4e65d2985aece70 Mon Sep 17 00:00:00 2001
From: Curtis Badke <curtis@badkid.ca>
Date: Sun, 13 Apr 2014 14:32:58 -0600
Subject: [PATCH 1/2] Cleanup unnecessary $scope members and api calls in team
 controller.

The Team api appears to do a deep fetch so additional fetches of
player objects are redundant.
---
 client/app/admin/controllers/team-details.js | 12 ++++--------
 client/app/admin/views/team-details.html     | 11 +++--------
 2 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/client/app/admin/controllers/team-details.js b/client/app/admin/controllers/team-details.js
index 50b9614..a838772 100644
--- a/client/app/admin/controllers/team-details.js
+++ b/client/app/admin/controllers/team-details.js
@@ -5,16 +5,12 @@ angular.module('freefootieApp')
 
     var Team = $resource('/api/teams/:id');
     var Division = $resource('/api/divisions/:id');
-    var Player = $resource('/api/players/:id');
 
     $scope.edit = {editing: false};
 
     var teamCheckpoint = $scope.currentTeam = Team.get({id: $routeParams.id}, function(team) {
-      teamCheckpoint = angular.copy(team);
-    	$scope.division = Division.get({id: team.division});
-    	$scope.players = (team.players || []).map(function(player){
-			return Player.get({id: player});
-		});
+       teamCheckpoint = angular.copy(team);
+    });
 
     $scope.$watch('currentTeam', function(newVal) {
       $scope.needsSave = !angular.equals(newVal, teamCheckpoint);
@@ -28,11 +24,11 @@ angular.module('freefootieApp')
              teamCheckpoint = angular.copy(team);
              $scope.needsSave = false;
            });
-    }
+    };
 
     $scope.cancel = function() {
       angular.copy(teamCheckpoint, $scope.currentTeam);
-    }
+    };
 
   });
 });
diff --git a/client/app/admin/views/team-details.html b/client/app/admin/views/team-details.html
index 56732a6..86cbbe7 100644
--- a/client/app/admin/views/team-details.html
+++ b/client/app/admin/views/team-details.html
@@ -8,19 +8,14 @@ <h1 class="topcoat-navigation-bar__title">{{currentTeam.name}}</h1>
 </div>
 <div class="topcoat-list">
   <ul class="topcoat-list__container">
-    <li class="topcoat-list__item" ng-hide="edit.editing">
+    <li class="topcoat-list__item">
         <property title="Team Name" model="currentTeam.name"></property>
         <property title="Coach" model="currentTeam.coach"></property>
         <property title="Coach Phone" model="currentTeam.phone"></property>
         <property title="Division" model="currentTeam.division" options="division._id as division.name for division in divisions"><property>
 	    </li>
-      <li class="topcoat-list__item" ng-show="edit.editing" style="line-height: 50px">
-        Coach:
-        <input type="text" class="topcoat-text-input" placeholder="Name" ng-model="currentTeam.coach" style="width: 100px"/>
-        <input type="text" class="topcoat-text-input" placeholder="Phone Number" ng-model="currentTeam.phone"/>
-      </li>
-       <li ng-repeat="player in players" class="topcoat-list__item">
-           {{player.number}}&nbsp - {{player.name}}
+       <li ng-repeat="player in currentTeam.players" class="topcoat-list__item">
+             {{player.number}}&nbsp - {{player.name}}
 	    </li>
       <li class="edit-row" ng-show="needsSave">
         <button class="topcoat-button--cta" ng-click="update(currentTeam)" >Save</button>

From f772ec6a96360a0f8a3da3042972d8e18c5d929f Mon Sep 17 00:00:00 2001
From: Curtis Badke <curtis@badkid.ca>
Date: Sun, 13 Apr 2014 14:34:19 -0600
Subject: [PATCH 2/2] WIP Start adding new team members.

This doesn't work as expected, I suspect that the Team api call isn't
saving the player values properly. If you save the newly added player
the data gets stored somewhere but a new _id is not generated for that
player.

Obviously this screen still needs the ability to actually set/change the
players values.
---
 client/app/admin/controllers/team-details.js | 6 +++---
 client/app/admin/views/team-details.html     | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/client/app/admin/controllers/team-details.js b/client/app/admin/controllers/team-details.js
index a838772..a95f69c 100644
--- a/client/app/admin/controllers/team-details.js
+++ b/client/app/admin/controllers/team-details.js
@@ -6,8 +6,6 @@ angular.module('freefootieApp')
     var Team = $resource('/api/teams/:id');
     var Division = $resource('/api/divisions/:id');
 
-    $scope.edit = {editing: false};
-
     var teamCheckpoint = $scope.currentTeam = Team.get({id: $routeParams.id}, function(team) {
        teamCheckpoint = angular.copy(team);
     });
@@ -30,5 +28,7 @@ angular.module('freefootieApp')
       angular.copy(teamCheckpoint, $scope.currentTeam);
     };
 
-  });
+    $scope.addPlayer = function() {
+      $scope.currentTeam.players.push({number: "", name: "New Player"});
+    };
 });
diff --git a/client/app/admin/views/team-details.html b/client/app/admin/views/team-details.html
index 86cbbe7..922aee3 100644
--- a/client/app/admin/views/team-details.html
+++ b/client/app/admin/views/team-details.html
@@ -23,4 +23,4 @@ <h1 class="topcoat-navigation-bar__title">{{currentTeam.name}}</h1>
       </li>
   </ul>
 </div>
-<div class="vs" style="margin-top:10px; font-weight: bold" ng-click="edit.editing=true">+</div>
+<div class="vs" style="margin-top:10px; font-weight: bold" ng-click="addPlayer()">+</div>