Fix Inno Setup installer build in GitHub Actions

[Computer-Tsu]

Summary

The GitHub Actions release pipeline hits a chain of Inno Setup failures in the Build Inno Setup Installer job during tagged release runs.

Current status

• Rolling latest-beta EXE releases are working.
• Versioned tagged releases can publish EXE assets even when the installer job fails.
• The installer build is still failing and needs follow-up.

What we found so far

• Inno Setup is present on the GitHub runner; this is not a missing-tool issue.
• The failures are happening inside the installer script or installer-job preparation steps.
• The installer debugging path has uncovered multiple separate blockers in sequence.

Sequence of installer blockers found

1. Invalid MinVersion value in installer/PortPane.iss.

   • Original recurring error: Value of [Setup] section directive "MinVersion" is invalid.
   • Current mitigation tested: normalize the line to MinVersion=10.0.17763 without the inline comment.

2. Missing file referenced by InfoBeforeFile.

   • Error: missing docs/INSTALLER_NOTE.txt.
   • Fix applied: add docs/INSTALLER_NOTE.txt to the repo.

3. Missing checksum file in the installer job workspace.

   • Error: missing publish/PortPane.exe.sha256.
   • Cause: the installer job rebuilds the app in its own workspace and did not generate the .sha256 file expected by the Inno script.
   • Fix applied: add a SHA-256 generation step in the installer job after dotnet publish.

4. Inno Pascal Script type mismatch in the placeholder verification block.

   • Error: Error on line 96 ... Type mismatch.
   • Failing line: LoadStringFromFile(HashPath, StoredHash);
   • Current mitigation: disable/comment out the placeholder hash-read block while stabilizing CI installer creation.

Interpretation

This now looks like a series of installer-script and installer-job issues rather than one single root cause.

Follow-up

• Confirm whether the normalized MinVersion line is now fully accepted in current CI runs.
• Confirm that the added note file and generated .sha256 file resolve those earlier blockers.
• Finish stabilizing the [Code] section so the installer can compile cleanly.
• Keep installer generation non-blocking for Beta until this is resolved.
• Revisit whether installer generation should become required for Stable releases.

[Computer-Tsu]

Additional installer-debugging notes from the temporary dev installer test tag:\n\n1. The original MinVersion failure was reproduced and appears fixed by normalizing the installer line to without the inline comment.\n\n2. After that was fixed, the next failure was a missing file referenced by :\n - \n - This file was then added to the repo.\n\n3. After the note file was added, the next failure was a missing checksum file during the installer job:\n - \n - Cause: the installer job rebuilds the app in its own workspace and did not generate the file that the Inno script expects.\n - Fix applied: add a SHA-256 generation step in the installer job after .\n\n4. After the checksum file was generated, the next failure moved into the Inno Pascal Script section:\n - \n - The failing line was \n - This appears to be placeholder verification logic, not essential installer packaging logic.\n\n5. Current action taken:\n - The placeholder verification block is being disabled/commented out while stabilizing CI installer creation.\n - The checksum file itself remains part of the packaged files.\n\nSo far this looks like a chain of installer-script/installer-job issues rather than one single root cause:\n- invalid format\n- missing \n- missing generation in installer job\n- placeholder Inno script type mismatch\n\nBeta EXE releases remain unblocked because tagged release publishing was already changed to proceed even when the installer job fails.\n