Disable forking in snapshot writing#2
Merged
Merged
Conversation
Author
|
I am unable to merge this. Have contacted Github, but I'm thinking the curse of Kyoto Tycoon is real and may have corrupted this repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing snapshots hangs forever because the forked child process can't acquire the db locks. Some details here.
This is a simpler alternative to #1 where we just stop forking. There's already an option to toggle. This should be just as effective in Cactus, since Cactus has it's own logic to detect hung servers