Skip to content

[task] Add CLARIFY protocol path eval #39

@AlexanderGardiner

Description

@AlexanderGardiner

Checks

  • I searched open and closed issues and pull requests and did not find a duplicate.

Area

Tests

Goal

The only existing eval (test_eval_harness_single_hop) exercises the DONE path. There is no eval verifying a real model correctly identifies a genuinely ambiguous query and emits CLARIFY rather than hallucinating forward with REMEMBER or DONE.

Run anchor.run with queries that are genuinely underspecified — no entity names, no clear intent — and assert:

  • result.stop_reason == "ask"
  • result.kind == "ask"
  • result.content contains a question directed at the user
  • The model does not emit DONE or REMEMBER for these inputs

Use 2-3 distinct underspecified queries to reduce flakiness risk from any single prompt.

The model may fail this test currently, that means the prompt needs fine tuning which is not included within this ticket

Definition of done

  • New file tests/evals/test_eval_clarify.py
  • Uses the shared ai_fn, light_ai_fn, and embed_fn fixtures from conftest.py
  • Marked @pytest.mark.eval
  • Passes uv run pytest -m eval tests/evals locally with Ollama running
  • Each case runs 3x minimum given the non-deterministic nature of the CLARIFY path

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: testsAutomated tests and test infrastructure.kind: maintenanceRepository maintenance or infrastructure work.status: ready-for-workTriaged and ready for a contributor to claim.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions