refactor(testing): rename TestableDb to DbOperations

TestableDb implied it was only for testing, but it is used as a
parameter type in production code. DbOperations is more accurate.

Author: brandonkachen

common/src/testing/mock-db.ts

@@ -1,19 +1,18 @@
 import type { Logger } from '@codebuff/common/types/contracts/logger'
 
 // ============================================================================
-// Testable Database Interface
+// Database Operations Interface
 // ============================================================================
 
 /* eslint-disable @typescript-eslint/no-explicit-any */
 /**
  * Minimal database interface for dependency injection in API routes.
  * Both the real CodebuffPgDatabase and test mocks can satisfy this interface.
  *
- * This allows tests to provide mock implementations without type casting.
  * Uses `any` for table/column parameters to be compatible with Drizzle ORM's
  * specific table types while remaining flexible for mocks.
  */
-export interface TestableDb {
+export interface DbOperations {
   insert: (table: any) => {
     values: (data: any) => PromiseLike<any>
   }
@@ -24,7 +23,7 @@ export interface TestableDb {
   }
   select: (columns?: any) => {
     from: (table: any) => {
-      where: (condition: any) => TestableDbWhereResult
+      where: (condition: any) => DbWhereResult
     }
   }
 }
@@ -35,7 +34,7 @@ export interface TestableDb {
  * - .orderBy(...).limit(n) for sorted queries
  * - .then() for promise-like resolution
  */
-export interface TestableDbWhereResult {
+export interface DbWhereResult {
   then: <TResult = any[]>(
     onfulfilled?: ((value: any[]) => TResult | PromiseLike<TResult>) | null | undefined,
   ) => PromiseLike<TResult>
@@ -364,9 +363,9 @@ export interface MockDbFactoryConfig {
 
 /**
  * Return type of createMockDb - a complete mock database object.
- * Implements TestableDb for type-safe dependency injection in tests.
+ * Implements DbOperations for type-safe dependency injection in tests.
  */
-export type MockDb = TestableDb
+export type MockDb = DbOperations
 
 /**
  * Creates a complete mock database object with insert, update, and select operations.
@@ -393,13 +392,13 @@ export type MockDb = TestableDb
  * })
  * ```
  */
-export function createMockDb(config: MockDbFactoryConfig = {}): TestableDb {
-  // Use type assertion since Mock types don't perfectly match TestableDb
+export function createMockDb(config: MockDbFactoryConfig = {}): DbOperations {
+  // Use type assertion since Mock types don't perfectly match DbOperations
   // but the runtime behavior is correct
   return {
     insert: createMockDbInsert(config.insert),
     update: createMockDbUpdate(config.update),
-    select: createMockDbSimpleSelect(config.select) as TestableDb['select'],
+    select: createMockDbSimpleSelect(config.select) as DbOperations['select'],
   }
 }
 
@@ -421,10 +420,10 @@ export function createMockDbWithErrors(config: {
   selectError?: Error
   /** Results to return from select queries (before any error is thrown) */
   selectResults?: unknown[]
-} = {}): TestableDb {
+} = {}): DbOperations {
   const { insertError, updateError, selectError, selectResults = [] } = config
 
-  // Use type assertion since Mock types don't perfectly match TestableDb
+  // Use type assertion since Mock types don't perfectly match DbOperations
   // but the runtime behavior is correct
   return {
     insert: mock(() => ({
@@ -466,7 +465,7 @@ export function createMockDbWithErrors(config: {
           return cb?.(selectResults) ?? selectResults
         }),
       })),
-    })) as TestableDb['select'],
+    })) as DbOperations['select'],
   }
 }
 
@@ -494,8 +493,8 @@ export function createMockDbWithErrors(config: {
  * })
  * ```
  */
-export function createSelectOnlyMockDb(selectResults: unknown[]): TestableDb {
-  const createWhereResult = (): TestableDbWhereResult => ({
+export function createSelectOnlyMockDb(selectResults: unknown[]): DbOperations {
+  const createWhereResult = (): DbWhereResult => ({
     then: <TResult = unknown[]>(
       onfulfilled?:
         | ((value: unknown[]) => TResult | PromiseLike<TResult>)

packages/internal/src/utils/version-utils.ts

@@ -2,7 +2,7 @@ import { and, desc, eq } from 'drizzle-orm'
 
 import * as schema from '@codebuff/internal/db/schema'
 
-import type { TestableDb } from '@codebuff/common/testing/mock-db'
+import type { DbOperations } from '@codebuff/common/testing/mock-db'
 
 export type Version = { major: number; minor: number; patch: number }
 
@@ -54,7 +54,7 @@ export function isGreater(v1: Version, v2: Version): boolean {
 export async function getLatestAgentVersion(params: {
   agentId: string
   publisherId: string
-  db: TestableDb
+  db: DbOperations
 }): Promise<Version> {
   const { agentId, publisherId, db } = params
 
@@ -96,7 +96,7 @@ export async function determineNextVersion(params: {
   agentId: string
   publisherId: string
   providedVersion?: string
-  db: TestableDb
+  db: DbOperations
 }): Promise<Version> {
   const { agentId, publisherId, providedVersion, db } = params
 
@@ -137,7 +137,7 @@ export async function versionExists(params: {
   agentId: string
   version: Version
   publisherId: string
-  db: TestableDb
+  db: DbOperations
 }): Promise<boolean> {
   const { agentId, version, publisherId, db } = params
 

web/src/app/api/v1/agent-runs/[runId]/steps/_post.ts

@@ -8,7 +8,7 @@ import { z } from 'zod'
 
 import type { TrackEventFn } from '@codebuff/common/types/contracts/analytics'
 import type { GetUserInfoFromApiKeyFn } from '@codebuff/common/types/contracts/database'
-import type { TestableDb } from '@codebuff/common/testing/mock-db'
+import type { DbOperations } from '@codebuff/common/testing/mock-db'
 import type {
   Logger,
   LoggerWithContextFn,
@@ -34,7 +34,7 @@ export async function postAgentRunsSteps(params: {
   logger: Logger
   loggerWithContext: LoggerWithContextFn
   trackEvent: TrackEventFn
-  db: TestableDb
+  db: DbOperations
 }) {
   const {
     req,

web/src/app/api/v1/agent-runs/_post.ts

@@ -8,7 +8,7 @@ import { z } from 'zod'
 
 import type { TrackEventFn } from '@codebuff/common/types/contracts/analytics'
 import type { GetUserInfoFromApiKeyFn } from '@codebuff/common/types/contracts/database'
-import type { TestableDb } from '@codebuff/common/testing/mock-db'
+import type { DbOperations } from '@codebuff/common/testing/mock-db'
 import type {
   Logger,
   LoggerWithContextFn,
@@ -43,7 +43,7 @@ async function handleStartAction(params: {
   userId: string
   logger: Logger
   trackEvent: TrackEventFn
-  db: TestableDb
+  db: DbOperations
 }) {
   const { data, userId, logger, trackEvent, db } = params
   const { agentId, ancestorRunIds } = data
@@ -105,7 +105,7 @@ async function handleFinishAction(params: {
   userId: string
   logger: Logger
   trackEvent: TrackEventFn
-  db: TestableDb
+  db: DbOperations
 }) {
   const { data, userId, logger, trackEvent, db } = params
   const {
@@ -174,7 +174,7 @@ export async function postAgentRuns(params: {
   logger: Logger
   loggerWithContext: LoggerWithContextFn
   trackEvent: TrackEventFn
-  db: TestableDb
+  db: DbOperations
 }) {
   const { req, getUserInfoFromApiKey, loggerWithContext, trackEvent, db } =
     params