fix collaboration extension corruption issue

Author: Titanium2099

src/addons/addons/collaboration/helpers/helper.js

@@ -491,7 +491,7 @@ export function pushLocalStateToYjs() {
             const extensionManager = vm.extensionManager;
             const extensionURLs = extensionManager.getExtensionURLs();
             const loadedExtensions = Array.from(extensionManager._loadedExtensions.keys()).map(id => {
-                return extensionURLs[id] || id;
+                return { URL: extensionURLs[id] || id, name: id };
             });
             if (loadedExtensions.length > 0) {
                 sharedExtensions.insert(0, loadedExtensions);
@@ -725,10 +725,11 @@ export function performInitialSync() {
         });
 
         const remoteExtensions = sharedExtensions.toArray();
-        remoteExtensions.forEach(urlOrId => {
-            if (!vm.extensionManager.isExtensionLoaded(urlOrId)) {
+        remoteExtensions.forEach(ext => {
+            const extURL = ext.URL || ext;
+            if (!vm.extensionManager.isExtensionLoaded(extURL)) {
 
-                vm.extensionManager.loadExtensionURL(urlOrId, false);
+                vm.extensionManager.loadExtensionURL(extURL, false);
             }
         });
 

src/addons/addons/collaboration/userscript.js

@@ -180,9 +180,10 @@ function attachYjsProvider() {
             if (event.transaction.origin === constants.LOCAL_EVENT_SYNC_ORIGIN) return;
 
             const remoteExtensions = constants.mutableRefs.sharedExtensions.toArray();
-            remoteExtensions.forEach(urlOrId => {
-                if (!constants.mutableRefs.vm.extensionManager.isExtensionLoaded(urlOrId)) {
-                    constants.mutableRefs.vm.extensionManager.loadExtensionURL(urlOrId, false);
+            remoteExtensions.forEach(ext => {
+                const extURL = ext.URL || ext;
+                if (!constants.mutableRefs.vm.extensionManager.isExtensionLoaded(extURL)) {
+                    constants.mutableRefs.vm.extensionManager.loadExtensionURL(extURL, false);
                 }
             });
         });
@@ -702,7 +703,11 @@ function attachYjsProvider() {
 
             constants.mutableRefs.ydoc.transact(() => {
                 const currentExts = constants.mutableRefs.sharedExtensions.toArray();
-                if (!currentExts.includes(extension)) {
+                const alreadyExists = currentExts.some(ext => {
+                    if (typeof ext === 'string') return ext === extension.URL || ext === extension.name;
+                    return ext.URL === extension.URL && ext.name === extension.name;
+                });
+                if (!alreadyExists) {
                     constants.mutableRefs.sharedExtensions.push([extension]);
                 }
             }, constants.LOCAL_EVENT_SYNC_ORIGIN);