From 563e14defd35603d22b4c55d7b49de288fd99a08 Mon Sep 17 00:00:00 2001 From: Chris Hirsch Date: Fri, 20 Nov 2026 09:33:40 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20trust=20every=20third-par?= =?UTF-8?q?ty=20tap=20in=20the=20Brewfile?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit brew bundle only loads entries from trusted taps. Add trust to each tap in use, drop unused taps, and check it in CI. --- .github/workflows/lint.yml | 11 +++++++++++ Brewfile | 29 +++++++++++++---------------- 2 files changed, 24 insertions(+), 16 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 58dd951..91d10bc 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -73,6 +73,17 @@ jobs: echo "::error::tap \"$t\" failed to add" fi done < /tmp/taps.txt + - name: Verify every tap in use is trusted in the Brewfile + run: | + # brew bundle refuses entries from a tap without `tap "", trusted: true` + fail=0 + while read -r t; do + grep -qxF "tap \"$t\", trusted: true" Brewfile || { + echo "::error::Brewfile needs: tap \"$t\", trusted: true" + fail=1 + } + done < /tmp/taps.txt + exit $fail - name: Verify every brew/cask entry resolves to a real formula/cask run: | # Short-name lookup can miss formulas from a tap added moments ago diff --git a/Brewfile b/Brewfile index 076382f..8deee6e 100644 --- a/Brewfile +++ b/Brewfile @@ -1,26 +1,23 @@ # brew bundle --file ~/Brewfile # Taps -tap "atombender/ktail", trusted:true -#tap "chef/chef" -tap "daveshanley/vacuum" -tap "derailed/k9s", trusted: true +# Homebrew only loads formulae and casks from third-party taps marked trusted +tap "atlassian/homebrew-acli", trusted: true +tap "atombender/ktail", trusted: true +tap "bufbuild/buf", trusted: true +tap "chef/chef", trusted: true +tap "datadog-labs/pack", trusted: true +tap "daveshanley/vacuum", trusted: true +# For dockle +tap "goodwithtech/r", trusted: true +# https://www.hashicorp.com/blog/announcing-hashicorp-homebrew-tap +tap "hashicorp/tap", trusted: true # For installing multiple java versions https://medium.com/w-logs/installing-java-11-on-macos-with-homebrew-7f73c1e9fadf #tap "homebrew/cask-versions" -tap "int128/kubelogin", trusted: true -# https://www.hashicorp.com/blog/announcing-hashicorp-homebrew-tap -tap "hashicorp/tap", trusted:true # https://github.com/puppetlabs/homebrew-puppet # tap "puppetlabs/puppet" -tap "derailed/k9s",trusted:true #tap "benwebber/tunnelblickctl" -# For dockle -tap "goodwithtech/r", trusted:true -tap "mike-engel/jwt-cli" # For Git -> Confluence Documentation #tap "kovetskiy/mark" -tap "datadog-labs/pack" -tap "atlassian/homebrew-acli", trusted:true - # Binaries # Atlassian/Jira cli @@ -239,7 +236,7 @@ cask "beekeeper-studio" cask "bruno" # Don't let the mac fall asleep (clickable) cask "caffeine" -cask "chef/chef/inspec", trust:true +cask "chef/chef/inspec" # Ebook Organizer cask "calibre" # Amazon Java JDK https://docs.aws.amazon.com/corretto/latest/corretto-11-ug/what-is-corretto-11.html @@ -334,7 +331,7 @@ cask "thunderbird" #cask "tunnelblick" #cask "tunnelblickctl" # FAST Swagger linter for cli -cask "daveshanley/vacuum/vacuum", trust:true +cask "daveshanley/vacuum/vacuum" #cask "vagrant" #cask "virtualbox" # Open source version of Visual Studio Code