Skip to content
This repository was archived by the owner on Dec 4, 2025. It is now read-only.

Commit d148ece

Browse files
committed
Merge branch 'jettzoeyExtensionApplication' of github.com:CSCI128/packtrain into jettzoeyExtensionApplication
2 parents dc285d8 + ec70f6e commit d148ece

2 files changed

Lines changed: 11 additions & 19 deletions

File tree

packtrain-service/src/main/java/edu/mines/packtrain/services/ExtensionService.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,13 +200,13 @@ public void processExtensionApplied(UUID extensionId, boolean extensionApplied,
200200
if (extensionApplied) {
201201
status = LateRequestStatus.APPLIED;
202202
}
203-
if (lateRequest != null) {
204-
lateRequest.setStatus(status);
205-
lateRequest.setDaysRequested(extensionDays);
206-
lateRequestRepo.save(lateRequest);
203+
if (lateRequest == null) {
204+
return;
207205
}
208206

209-
//is this correct?
207+
lateRequest.setStatus(status);
208+
lateRequest.setDaysRequested(extensionDays);
209+
lateRequestRepo.save(lateRequest);
210210

211211
}
212212

packtrain-service/src/test/java/edu/mines/packtrain/services/TestExtensionService.java

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,13 @@
77
import edu.mines.packtrain.repositories.LateRequestRepo;
88
import edu.mines.packtrain.seeders.CourseSeeders;
99

10-
import static org.mockito.ArgumentMatchers.any;
11-
1210
import java.util.UUID;
1311

1412
import org.junit.jupiter.api.AfterEach;
1513
import org.junit.jupiter.api.Assertions;
1614
import org.junit.jupiter.api.BeforeAll;
1715
import org.junit.jupiter.api.Test;
18-
import org.mockito.ArgumentCaptor;
19-
import org.mockito.InjectMocks;
20-
import org.mockito.Mock;
21-
import org.mockito.Mockito;
16+
2217
import org.springframework.beans.factory.annotation.Autowired;
2318
import org.springframework.boot.test.context.SpringBootTest;
2419

@@ -55,20 +50,17 @@ void verifyGetAllExtensions(){
5550

5651
}
5752

58-
53+
@Test
5954
void verifyProcessExtensionApplied(){
6055
LateRequest mockLateRequest = new LateRequest();
6156
mockLateRequest.setDaysRequested(4);
6257
mockLateRequest.setStatus(LateRequestStatus.IGNORED);
6358

64-
Mockito.when(lateRequestRepo.getLateRequestById(any(UUID.class))).thenReturn(mockLateRequest);
65-
Mockito.when(lateRequestRepo.save(any())).thenReturn(null);
66-
59+
mockLateRequest = lateRequestRepo.save(mockLateRequest);
60+
6761
extensionService.processExtensionApplied(UUID.randomUUID(), true, 2);
68-
ArgumentCaptor<LateRequest> requestCaptor = ArgumentCaptor.forClass(LateRequest.class);
69-
Mockito.verify(lateRequestRepo).save(requestCaptor.capture());
70-
71-
LateRequest capturedRequest = requestCaptor.getValue();
62+
LateRequest capturedRequest = lateRequestRepo.getLateRequestById(mockLateRequest.getId());
63+
7264
Assertions.assertEquals(capturedRequest.getStatus(), LateRequestStatus.APPLIED);
7365
Assertions.assertEquals(capturedRequest.getDaysRequested(), 2);
7466

0 commit comments

Comments
 (0)