Hey @GunawanAhmad , thanks again for the keyboard navigation feature! I've been testing it on the dev branch and it feels great.
I did notice one small issue, however. When the clipboard popup is open, clicking anywhere outside of it no longer closes the window. It currently only closes when pressing the Esc key.
Because we introduced explicit keyboard focus, Wayland/Quickshell is likely trapping the focus. Based on Brain_Shell's architecture, this is usually caused by one of two things:
- Focus Mode: If
ClipboardPopup.qml uses keyboardFocus: WlrKeyboardFocus.Exclusive, it will prevent outside clicks from registering. It needs to be WlrKeyboardFocus.OnDemand.
- Missing Active Check: We might need to add/restore a window focus listener at the root of the popup (e.g.,
onActiveChanged: if (!active) Popups.clipboardOpen = false) to catch when Hyprland focuses a different window.
Would you be open to taking a look and submitting a quick follow-up PR targeting the dev branch to patch this?
Let me know! If you are too busy right now, no worries at all just let me know and I can jump in and add the fix to dev before the next release.
Hey @GunawanAhmad , thanks again for the keyboard navigation feature! I've been testing it on the
devbranch and it feels great.I did notice one small issue, however. When the clipboard popup is open, clicking anywhere outside of it no longer closes the window. It currently only closes when pressing the
Esckey.Because we introduced explicit keyboard focus, Wayland/Quickshell is likely trapping the focus. Based on Brain_Shell's architecture, this is usually caused by one of two things:
ClipboardPopup.qmluseskeyboardFocus: WlrKeyboardFocus.Exclusive, it will prevent outside clicks from registering. It needs to beWlrKeyboardFocus.OnDemand.onActiveChanged: if (!active) Popups.clipboardOpen = false) to catch when Hyprland focuses a different window.Would you be open to taking a look and submitting a quick follow-up PR targeting the
devbranch to patch this?Let me know! If you are too busy right now, no worries at all just let me know and I can jump in and add the fix to
devbefore the next release.