refactor(settings): update ModSettingsValueBinding to IModSettingsValueBinding for improved type safety

- Replaced instances of ModSettingsValueBinding<RitsuLibSettings, T> with IModSettingsValueBinding<T> across multiple files to enhance type safety and consistency.
- Updated method signatures in CardPngExportSettingsActions, CompendiumPngExportSettingsActions, and HarmonyPatchDumpSaveDialog to reflect the new binding interface.
- Adjusted related settings properties in RitsuLibModSettingsUiBindings for better integration with the new binding structure.

Author: BAKAOLC

Diagnostics/CardExport/CardPngExportSettingsActions.cs

@@ -9,12 +9,12 @@ namespace STS2RitsuLib.Diagnostics.CardExport
     internal static class CardPngExportSettingsActions
     {
         internal static void TryBeginFromSettings(
-            ModSettingsValueBinding<RitsuLibSettings, string> pathBinding,
-            ModSettingsValueBinding<RitsuLibSettings, bool> includeHoverBinding,
-            ModSettingsValueBinding<RitsuLibSettings, bool> includeUpgradesBinding,
-            ModSettingsValueBinding<RitsuLibSettings, double> scaleBinding,
-            ModSettingsValueBinding<RitsuLibSettings, string> filterBinding,
-            ModSettingsValueBinding<RitsuLibSettings, bool> includeHiddenFromLibraryBinding)
+            IModSettingsValueBinding<string> pathBinding,
+            IModSettingsValueBinding<bool> includeHoverBinding,
+            IModSettingsValueBinding<bool> includeUpgradesBinding,
+            IModSettingsValueBinding<double> scaleBinding,
+            IModSettingsValueBinding<string> filterBinding,
+            IModSettingsValueBinding<bool> includeHiddenFromLibraryBinding)
         {
             var rawPath = pathBinding.Read().Trim();
             if (string.IsNullOrWhiteSpace(rawPath))

Diagnostics/CompendiumExport/CompendiumPngExportSettingsActions.cs

@@ -7,10 +7,10 @@ namespace STS2RitsuLib.Diagnostics.CompendiumExport
     internal static class CompendiumPngExportSettingsActions
     {
         internal static void TryBeginRelicDetailFromSettings(
-            ModSettingsValueBinding<RitsuLibSettings, string> pathBinding,
-            ModSettingsValueBinding<RitsuLibSettings, double> scaleBinding,
-            ModSettingsValueBinding<RitsuLibSettings, string> filterBinding,
-            ModSettingsValueBinding<RitsuLibSettings, bool> includeHoverBinding)
+            IModSettingsValueBinding<string> pathBinding,
+            IModSettingsValueBinding<double> scaleBinding,
+            IModSettingsValueBinding<string> filterBinding,
+            IModSettingsValueBinding<bool> includeHoverBinding)
         {
             if (!TryValidatePathAndEnv(pathBinding, out var path))
                 return;
@@ -28,9 +28,9 @@ internal static void TryBeginRelicDetailFromSettings(
         }
 
         internal static void TryBeginPotionDetailFromSettings(
-            ModSettingsValueBinding<RitsuLibSettings, string> pathBinding,
-            ModSettingsValueBinding<RitsuLibSettings, double> scaleBinding,
-            ModSettingsValueBinding<RitsuLibSettings, string> filterBinding)
+            IModSettingsValueBinding<string> pathBinding,
+            IModSettingsValueBinding<double> scaleBinding,
+            IModSettingsValueBinding<string> filterBinding)
         {
             if (!TryValidatePathAndEnv(pathBinding, out var path))
                 return;
@@ -48,7 +48,7 @@ internal static void TryBeginPotionDetailFromSettings(
         }
 
         private static bool TryValidatePathAndEnv(
-            ModSettingsValueBinding<RitsuLibSettings, string> pathBinding, out string path)
+            IModSettingsValueBinding<string> pathBinding, out string path)
         {
             path = pathBinding.Read().Trim();
             if (string.IsNullOrWhiteSpace(path))

Settings/Integration/Patches/HarmonyPatchDumpSaveDialog.cs

@@ -6,7 +6,7 @@ namespace STS2RitsuLib.Settings
     internal static class HarmonyPatchDumpSaveDialog
     {
         internal static void Show(
-            ModSettingsValueBinding<RitsuLibSettings, string> outputPathBinding,
+            IModSettingsValueBinding<string> outputPathBinding,
             IModSettingsUiActionHost uiHost)
         {
             var tree = Engine.GetMainLoop() as SceneTree;