Mangahere latest chapter broken

[Snipeon]

AMR is wrongly updating all Mangahere latest chapters. All the latest chapters from Mangahere seem to have a file:// added in at the beginning.

With ref to here.

[Snipeon]

Seems like Mangafox has also been struck with the same problem.

[twluo]

From what I can tell, it might be because MangaHere just switched to htpps. Would need to change the rule here https://community.allmangasreader.com/latest_v2/MangaHere.js

[twluo]

I am writing a really quick fix for it that is probably going to increase latency but at least it will fix the issue. I can share it once I'm at a point that's worth sharing if you're interested.

[twluo]

Another fix could be changing the .attr("href") to just .href in https://github.com/AllMangasReader-dev/mirrors/blob/master/MangaHere.js. That would make it so that it returns the complete url with the https:// as opposed to just // but I haven't had the chance to test that yet.

[Snipeon]

Nice, good work. Too bad I suck at java.

Meaning that I can't help much.

[braiam]

Nice, good work. Too bad I suck at java.

Actually javascript.

[Snipeon]

Anything with java in the name, I suck at.

[Stubbs9410]

Hi, sorry to bother, but the chrome extension of All Mangas Reader versions 1.5.10.2 is not working can I know if you will make a new extension, fix I really love this extension been using it a long time and I check github but I don't know Java script.
Please respond to the message

[jacobmix]

I use AMR as an unpacked extension, and only thing i've edited is this line of manifest.json:
http://prntscr.com/gqh0m7 | And use this to remove the Chrome start popup warning.

Do i have to edit some file with this?
https://github.com/AllMangasReader-dev/mirrors/blob/master/MangaHere.js
If so what file? If not is there anything else i can do to get the fix?

Edit: Using All Mangas Reader (Beta channel) 1.5.10.2 Pic of the extension folder:
http://prntscr.com/gqk68v

[twluo]

So right now I was in the middle of a quick fix which was basically appending https: to every mangahere url since it seems that its returning as //www.mangahere.co/* as opposed to http://ww.mangahere.co. I'm not sure if it has to do with the fact that mangahere switched to https. MY solution fixes the issue but it might create some latency issues. Right now it detects that if you're in the last chapter then there's no new chapter but I'm still having some issue with updating what's the latest chapter. Once I get that part done I will fork it and share it.

[twluo]

From the little investigating I did yesterday night, I noticed that if you go to a mangahere detail page such as https://www.mangahere.co/manga/14_sai_no_koi/ and then you can see from https://github.com/AllMangasReader-dev/mirrors/blob/84c4a8f370b116c9b0edd798116de60067207e1e/MangaHere.js#L52-L54 that it uses .attr('href') to fetch the url. If you go to the detail page and run $(".detail_list ul li span.left a").attr("href"); on the console you will get "//www.mangahere.co/manga/14_sai_no_koi/v02/c035.7/" back. Now if you were to run $(".detail_list ul li span.left a")[0].href then you get "https://www.mangahere.co/manga/14_sai_no_koi/v02/c035.7/" which is the complete url

Same issue on https://github.com/AllMangasReader-dev/mirrors/blob/84c4a8f370b116c9b0edd798116de60067207e1e/MangaHere.js#L75-L77

By using .attr("href") we are getting how they wrote it but if we use .href then we get the absolute path.

[twluo]

https://github.com/twluo/AMR Is a very dirty fix but it gets stuff working. There's still some issues with the counter. It seems that the counter doesn't refresh properly but you can get it to refresh by just reloading the extension.

[Snipeon]

Good job. Though if you are able to grab the correct URL by changing the Mangahere.js, why are you editing the files in the main js folder? Pardon my noobness.

[twluo]

I'm not sure how the mirrors work and I don't really want to spent an entire night investigating it. I try copying the MangaHere.js into my local and try to use the local mirror instead of the repo one but it kept failing so I gave up. Also I just updated my fork and should be able to refresh properly.

[Snipeon]

Nice. Good job.