Skip to content

Commit 3d4469c

Browse files
committed
Updating verbosity and changing png to pdf
1 parent 5d12c67 commit 3d4469c

2 files changed

Lines changed: 18 additions & 8 deletions

File tree

prodtests/full-system-test/analyze_gpu_benchmarks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ def main():
266266
"-o",
267267
"--output",
268268
type=Path,
269-
default=Path("gpu_reconstruction_times.png"),
269+
default=Path("gpu_reconstruction_times.pdf"),
270270
help="Output plot filename",
271271
)
272272
parser.add_argument(
@@ -391,7 +391,7 @@ def main():
391391
plt.title("gpu-reconstruction timeslice processing duration")
392392
plt.legend()
393393
plt.tight_layout()
394-
plt.savefig(args.output, dpi=150)
394+
plt.savefig(args.output)
395395

396396
print(f"{BOLD}Input file:{RESET} {args.logfile}")
397397
print(f"{CYAN}{BOLD}Complete timeslices found:{RESET} {n_total}")

prodtests/full-system-test/gen_single_gpu_rtc_benchmark.sh

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,18 @@ case "${GPUTYPE:-}" in
3030
;;
3131
esac
3232

33-
if [[ -z "${FILEWORKDIR:-}" ]]; then
34-
echo "ERROR: FILEWORKDIR must be set to a directory containing raw TF input files" >&2
33+
if [[ -z "${FILEWORKDIR:-}" && -z "${INPUT_FILE_LIST:-}" ]]; then
34+
echo "ERROR: either FILEWORKDIR or INPUT_FILE_LIST must be set" >&2
35+
exit 1
36+
fi
37+
38+
if [[ -n "${FILEWORKDIR:-}" && "$FILEWORKDIR" != /* ]]; then
39+
echo "ERROR: FILEWORKDIR must be an absolute path: $FILEWORKDIR" >&2
40+
exit 1
41+
fi
42+
43+
if [[ -n "${INPUT_FILE_LIST:-}" && "$INPUT_FILE_LIST" != /* ]]; then
44+
echo "ERROR: INPUT_FILE_LIST must be an absolute path: $INPUT_FILE_LIST" >&2
3545
exit 1
3646
fi
3747

@@ -144,18 +154,18 @@ if [[ "$RUN_BENCHMARK" == "1" ]]; then
144154
echo "# Full log: $log"
145155

146156
# --------------------------------------------------------------------------------------------------------------------
147-
# Analyze gpu-reconstruction processing timeslice timing and write PNG next to the log.
157+
# Analyze gpu-reconstruction processing timeslice timing and write PDF next to the log.
148158

149159
: "${GPU_RECO_ANALYZER:=$O2_ROOT/prodtests/full-system-test/analyze_gpu_benchmarks.py}"
150160

151161
if [[ -f "$GPU_RECO_ANALYZER" ]]; then
152-
analysis_png="${log%.log}_gpu_reconstruction_times.png"
162+
analysis_pdf="${log%.log}_gpu_reconstruction_times.pdf"
153163

154164
echo "# Analyzing gpu-reconstruction timeslices"
155165
echo "# analyzer: $GPU_RECO_ANALYZER"
156-
echo "# plot: $analysis_png"
166+
echo "# plot: $analysis_pdf"
157167

158-
python3 "$GPU_RECO_ANALYZER" --logfile "$log" --output "$analysis_png" || {
168+
python3 "$GPU_RECO_ANALYZER" --logfile "$log" --output "$analysis_pdf" || {
159169
echo "WARNING: gpu-reconstruction timing analysis failed" >&2
160170
}
161171
else

0 commit comments

Comments
 (0)