From aef43b3898592874d745027a64861b123274799a Mon Sep 17 00:00:00 2001 From: Harshul jain Date: Thu, 15 Oct 2026 05:09:49 -0400 Subject: [PATCH] chore: require labels on a PR, in the skill that forgets them MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thirty-odd PRs had no labels, including every one from the last two days, because this skill never asked for them. The issue skill does, which is exactly why issues were labelled and PRs were not — a mechanical step gets skipped when nothing asks for it. Both axes are mechanical, not judgement: `type:` is whatever the conventional-commit prefix already says, and `area:` follows the scope. The labels are what make `gh pr list --label area:voice` answer "what have we changed about voice"; without them that history is greppable by title only. Also says to use the project's `type:` vocabulary rather than GitHub's stock `bug` / `documentation` / `enhancement`. Those exist only because they ship with a new repo, and four PRs had picked them up — a repo carrying both has two names for one thing and neither filter returns everything. --- .claude/skills/agentship-pr/SKILL.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/.claude/skills/agentship-pr/SKILL.md b/.claude/skills/agentship-pr/SKILL.md index 2ab9e41..2ca175f 100644 --- a/.claude/skills/agentship-pr/SKILL.md +++ b/.claude/skills/agentship-pr/SKILL.md @@ -103,6 +103,26 @@ Add the `## [Unreleased]` changelog entry. That section *is* the next release's missing entry means the work ships unannounced — and a tag with no matching section fails the release workflow outright. +## Label it + +**Same two axes as an issue, applied to the PR too** — `--label` on `gh pr create`, not as an +afterthought: + +- `type:` — bug · feature · docs · chore. This is not a judgement call: it is whatever the + conventional-commit prefix already says. `fix(voice):` is `type:bug` and `area:voice`. +- `area:` — core · langgraph · voice · service · observability · cli · demo. Studio lives in + `agentship-service`, so a Studio change is `area:service`. +- `release` as well, on a version bump or the release plumbing. + +This was missed on thirty-odd PRs because the skill did not ask for it, which is the only +reason a mechanical step gets skipped. The labels are what make `gh pr list --label area:voice` +answer "what have we changed about voice", and without them that history is only greppable by +title. + +Use the `type:` vocabulary, never GitHub's stock `bug` / `documentation` / `enhancement`. Those +exist because they ship with a new repo, and a repo with both has two names for one thing and +neither filter returns everything. + ## After opening Watch CI to completion (`gh pr checks --watch`) and report the result honestly. Do not