cmd/codeaf: the model-warm rows name a catalog warm that closeAll now joins

The change note takes the PR number (1264 named a PR that has already landed).
With the catalog warm owned, cancelled and joined through Models.Close, the
chatv3/models and engine/models rows in the guard.Go inventory law no longer
carry an open writer one package down: each names the waiter joined since #1179
and the internal/catalog warm that v3Process.closeAll now cancels and joins.
chatv3/sweep-home is the one known-open row left.

Author: agentfield-bot

cmd/codeaf/chatv3_guard_class_test.go

@@ -14,8 +14,8 @@ import (
 // TestV3ProcessGuardGoClass is the inventory law for goroutines started by a
 // v3 process or launch. A long-lived writer must identify both its stop and the
 // closeAll join. chatv3/models and engine/models name the process waiter, joined
-// since #1179; the internal/catalog catalog/warm goroutine each one starts is a
-// separate open writer one package down, owned by the catalog-warm-close cell.
+// since #1179, and the internal/catalog warm each one starts, which closeAll now
+// cancels and joins through Models.Close.
 // The remaining known-open row (chatv3/sweep-home) names the later cell that owns it;
 // deleting a row is part of landing that cell.
 func TestV3ProcessGuardGoClass(t *testing.T) {
@@ -26,8 +26,8 @@ func TestV3ProcessGuardGoClass(t *testing.T) {
 		"chatv3/standing":         {kind: "joined writer", stop: "v3Process.standingStop", join: "v3Process.closeAll calls stopStandingTicks"},
 		"chatv3/standing-stop":    {kind: "joined helper", stop: "standingStop is closed", join: "chatv3/standing closes standingDone after this helper returns"},
 		"pool/judge-sweep":        {kind: "joined writer", stop: "pool errand context", join: "v3Process.closeAll calls stopPoolErrands"},
-		"chatv3/models":           {kind: "joined waiter, downstream catalog/warm still open", stop: "warmModels waiter on the pool errand context", join: "v3Process.closeAll calls stopPoolErrands, joining the waiter since #1179; the internal/catalog catalog/warm it starts is not yet joined, owned by the catalog-warm-close cell"},
-		"engine/models":           {kind: "joined waiter, downstream catalog/warm still open", stop: "warmModels waiter on the pool errand context", join: "v3Process.closeAll calls stopPoolErrands, joining the waiter since #1179; the internal/catalog catalog/warm it starts is not yet joined, owned by the catalog-warm-close cell"},
+		"chatv3/models":           {kind: "joined writer", stop: "warmModels waiter on the pool errand context, and the catalog's own warm context", join: "v3Process.closeAll calls stopPoolErrands for the waiter (since #1179) and Models.Close, which cancels and joins the internal/catalog warm"},
+		"engine/models":           {kind: "joined writer", stop: "warmModels waiter on the pool errand context, and the catalog's own warm context", join: "v3Process.closeAll calls stopPoolErrands for the waiter (since #1179) and Models.Close, which cancels and joins the internal/catalog warm"},
 		"chatv3/sweep-home":       {kind: "KNOWN-OPEN writer", owner: "later home-sweep ownership cell (class target three)"},
 		"chatv3/background":       {kind: "one-shot", stop: "repairBackgroundChecks returns after one bounded Drift/Install pass"},
 		"chatv3/once-questions":   {kind: "one-shot", stop: "agent.Close closes the WatchQuestions channel consumed by the range"},

…released/1264-catalog-lazy-warm-close.md …released/1274-catalog-lazy-warm-close.mddocs/changes/unreleased/1264-catalog-lazy-warm-close.md renamed to docs/changes/unreleased/1274-catalog-lazy-warm-close.md docs/changes/unreleased/1264-catalog-lazy-warm-close.md renamed to docs/changes/unreleased/1274-catalog-lazy-warm-close.md

@@ -1,7 +1,7 @@
 ---
 kind: fixed
 title: closing a process cancels and joins lazy catalog warming before a late cache write
-pr: 1264
+pr: 1274
 surface: [engine]
 invalidates:
   - "Lazy catalog warming could outlive process close and write its cache afterward, including beneath a home selected by a later launch. Close now cancels and joins the warm, and a fetch that succeeds after cancellation does not write the cache."