Skip to content

Commit e2d1d01

Browse files
committed
refactor: address Greptile code review feedback
1 parent 3f191d2 commit e2d1d01

3 files changed

Lines changed: 5 additions & 8 deletions

File tree

‎src/cm/commandRegistry.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1668,7 +1668,10 @@ async function loadCustomKeyBindings() {
16681668
if (updated) {
16691669
bindingsFile
16701670
.writeFile(JSON.stringify(bindings, undefined, 2))
1671-
.catch(() => {});
1671+
.catch((error) => {
1672+
window.log?.("error", "Failed to back-fill new key bindings!");
1673+
window.log?.("error", error);
1674+
});
16721675
}
16731676
}
16741677
} else {

‎src/lib/commands.js‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -303,9 +303,6 @@ export default {
303303
"next-file-history"() {
304304
editorManager.openNextEditorFromHistory?.();
305305
},
306-
openNextEditorFromHistory() {
307-
editorManager.openNextEditorFromHistory?.();
308-
},
309306
async open(page) {
310307
switch (page) {
311308
case "settings":
@@ -387,9 +384,6 @@ export default {
387384
"prev-file-history"() {
388385
editorManager.openPreviousEditorFromHistory?.();
389386
},
390-
openPreviousEditorFromHistory() {
391-
editorManager.openPreviousEditorFromHistory?.();
392-
},
393387
"read-only"() {
394388
const file = editorManager.activeFile;
395389
file.editable = !file.editable;

‎src/lib/editorManager.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4218,7 +4218,7 @@ async function EditorManager($header, $body) {
42184218
setNativeContextMenuDisabled(isFocused);
42194219

42204220
function handleContentFocus(_event) {
4221-
setActivePane(pane, { emitSwitch: false });
4221+
setActivePane(pane);
42224222
setNativeContextMenuDisabled(true);
42234223
const activeFile = pane.activeFile;
42244224
if (activeFile) {

0 commit comments

Comments
 (0)