diff --git a/gns3-gui-2.1.4/gns3/update_manager.py b/gns3-gui-2.1.4/gns3/update_manager.py index ae750b9..9f7bb68 100644 --- a/gns3-gui-2.1.4/gns3/update_manager.py +++ b/gns3-gui-2.1.4/gns3/update_manager.py @@ -230,4 +230,23 @@ def _extractTgz(self, tgz): for member in members: # Path separator is always / even on windows member.name = member.name.split("/", 1)[1] - tar.extractall(path=self._package_directory, members=members) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=self._package_directory, members=members)