From d744560bba0bacc73b2169e4839c8bf91a736bdd Mon Sep 17 00:00:00 2001 From: 0vercl0k <1476421+0vercl0k@users.noreply.github.com> Date: Tue, 30 Sep 2025 19:38:47 -0700 Subject: [PATCH 1/6] try to fix https://github.com/lief-project/LIEF/issues/1244 --- .github/workflows/udmp-parser.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/udmp-parser.yml b/.github/workflows/udmp-parser.yml index 683e182..e5b87f8 100644 --- a/.github/workflows/udmp-parser.yml +++ b/.github/workflows/udmp-parser.yml @@ -28,7 +28,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v5 - name: Environment Setup (Windows) if: matrix.variant.os == 'windows-2025' @@ -86,10 +86,10 @@ jobs: CMAKE_FLAGS: "-DBUILD_PARSER:BOOL=OFF -DBUILD_PYTHON_BINDING:BOOL=ON" steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v5 - name: Build / test wheels - uses: pypa/cibuildwheel@v2.21.3 + uses: pypa/cibuildwheel@v3.2.0 with: package-dir: ./src/python From 7f4af719c57d5749f1161d34adc06a8d0d9c9114 Mon Sep 17 00:00:00 2001 From: 0vercl0k <1476421+0vercl0k@users.noreply.github.com> Date: Tue, 30 Sep 2025 19:42:40 -0700 Subject: [PATCH 2/6] cp37: 'Invalid skip selector: 'cp37-*'. cibuildwheel 3.x no longer supports Python < 3.8.' pp: 'Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled.' --- src/python/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/python/pyproject.toml b/src/python/pyproject.toml index ba66485..4dd3183 100644 --- a/src/python/pyproject.toml +++ b/src/python/pyproject.toml @@ -40,7 +40,7 @@ cmake.minimum-version = "3.21" [tool.cibuildwheel] build-verbosity = 1 -skip = "cp37-* pp* *musllinux*" +skip = "*musllinux*" before-test = "pip install -U -r {project}/src/python/tests/requirements.txt" test-command = "pytest -vvv {project}/src/python/tests" From 8f005f250742e21979e597db119581ca3fef799f Mon Sep 17 00:00:00 2001 From: 0vercl0k <1476421+0vercl0k@users.noreply.github.com> Date: Tue, 30 Sep 2025 20:31:21 -0700 Subject: [PATCH 3/6] try? --- src/python/pyproject.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/src/python/pyproject.toml b/src/python/pyproject.toml index 4dd3183..9871684 100644 --- a/src/python/pyproject.toml +++ b/src/python/pyproject.toml @@ -40,7 +40,6 @@ cmake.minimum-version = "3.21" [tool.cibuildwheel] build-verbosity = 1 -skip = "*musllinux*" before-test = "pip install -U -r {project}/src/python/tests/requirements.txt" test-command = "pytest -vvv {project}/src/python/tests" From a1283441a8913d6ea4d5a1fff0e43002d0e3a542 Mon Sep 17 00:00:00 2001 From: 0vercl0k <1476421+0vercl0k@users.noreply.github.com> Date: Thu, 2 Oct 2025 18:52:32 -0700 Subject: [PATCH 4/6] macos-13 is getting deprecated --- .github/workflows/udmp-parser.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/udmp-parser.yml b/.github/workflows/udmp-parser.yml index e5b87f8..b04436e 100644 --- a/.github/workflows/udmp-parser.yml +++ b/.github/workflows/udmp-parser.yml @@ -16,10 +16,8 @@ jobs: - {os: ubuntu-22.04, generator: clang, arch: x64, config: RelWithDebInfo, } - {os: ubuntu-24.04, generator: gcc, arch: x64, config: RelWithDebInfo, } - {os: ubuntu-24.04, generator: clang, arch: x64, config: RelWithDebInfo, } - - {os: macos-13, generator: clang, arch: x64, config: Release, } - # - {os: macos-13-xlarge, generator: clang, arch: arm64, config: Release, } # Paying runner - - {os: macos-14, generator: clang, arch: arm64, config: Release, } - # - {os: macos-14-large, generator: clang, arch: x64, config: Release, } # Paying runner + - {os: macos-15-intel, generator: clang, arch: x64, config: Release, } + - {os: macos-15, generator: clang, arch: arm64, config: Release, } runs-on: ${{ matrix.variant.os }} name: parser / ${{ matrix.variant.os }} / ${{ matrix.variant.generator }} / ${{ matrix.variant.arch }} env: From 9789ebf25308bda808b9f1276806b202ed9e1a66 Mon Sep 17 00:00:00 2001 From: 0vercl0k <1476421+0vercl0k@users.noreply.github.com> Date: Thu, 2 Oct 2025 20:17:20 -0700 Subject: [PATCH 5/6] try this? --- src/python/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/python/CMakeLists.txt b/src/python/CMakeLists.txt index a7da7b1..fad42bc 100644 --- a/src/python/CMakeLists.txt +++ b/src/python/CMakeLists.txt @@ -38,7 +38,7 @@ find_package(nanobind CONFIG REQUIRED) set(CMAKE_CXX_STANDARD 20) -nanobind_add_module(udmp_parser NB_STATIC src/udmp_parser_utils.cc src/udmp_parser.cc) +nanobind_add_module(udmp_parser STABLE_ABI src/udmp_parser_utils.cc src/udmp_parser.cc) if(MSVC) target_link_libraries(udmp_parser PRIVATE DbgHelp.lib) From 0404934c4c99a275917584fbd46387d4f7099b37 Mon Sep 17 00:00:00 2001 From: 0vercl0k <1476421+0vercl0k@users.noreply.github.com> Date: Thu, 2 Oct 2025 20:34:07 -0700 Subject: [PATCH 6/6] fix --- .github/workflows/udmp-parser.yml | 3 +-- src/python/pyproject.toml | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/udmp-parser.yml b/.github/workflows/udmp-parser.yml index b04436e..2bec189 100644 --- a/.github/workflows/udmp-parser.yml +++ b/.github/workflows/udmp-parser.yml @@ -76,8 +76,7 @@ jobs: # Available runners: https://github.com/actions/runner-images - {os: windows-2025, config: RelWithDebInfo } - {os: ubuntu-22.04, config: RelWithDebInfo } - # most up to date free intel based osx? - - {os: macos-13, config: Release } + - {os: macos-15-intel, config: Release } runs-on: ${{ matrix.variant.os }} name: bindings / ${{ matrix.variant.os }} env: diff --git a/src/python/pyproject.toml b/src/python/pyproject.toml index 9871684..cc6b8b6 100644 --- a/src/python/pyproject.toml +++ b/src/python/pyproject.toml @@ -40,6 +40,8 @@ cmake.minimum-version = "3.21" [tool.cibuildwheel] build-verbosity = 1 +# udmp_parser builds fine for this target, but not `lief`. +skip = "cp314t-*" before-test = "pip install -U -r {project}/src/python/tests/requirements.txt" test-command = "pytest -vvv {project}/src/python/tests"